Trying :height…. Can you feed in height of < 1.0? Nothing seems to work when I try that.. Hmm… no value I try seems to make a difference… https://github.com/realgenekim/simulator-couch-paint/blob/8ed0afb2f362a9702cf1a1eef5176a0e08507834/src/ui/membrane_ui.clj#L275

Wait a second.. I think it worked. Just didn’t update!

Never mind — it works! 🎉

I was doing the same thing.

Just setting the line :height to 1 seems to tighten everything. For whatever reason, adding emoji adjusts the default :height to something greater than 1.

That might also fix the couch error from earlier

Another gotcha here is that defui components use caching. That means if you update a function that component relies on, it won't re-evaluate the component unless it gets a new value to render. You can force the component to re-evaluate to by re-evaluating any defui component.

Baffled by this one — recording (this time in 4K, is that better?) font-size isn’t being picked up by component. Caching? Okay, let me try that. But, color changes, but not font size? https://capture.dropbox.com/HQelqbh1xxyglXTg (Gimme 30s. will check into repo.)

https://github.com/realgenekim/simulator-couch-paint/blob/027291d6beb29e4131e9a8f3d4b81bbe9c9949ea/src/ui/membrane_ui.clj#L214

I bet if you make changes and then re-evaluate any defui component, that it will update everything.

Hmm. I’m reloading entire namespace everytime, which should re-eval all defui, yes?

yea

DOH! Big typo on my part. I think I found it.

oh, right. I think :font-size should be part of the style map.

Yes. Sorry about that!!! Okay, that’s a wrap for today! Wooot! Thx again!

Oh, the best part! The number slider as a scrubber! https://capture.dropbox.com/wbNYMpqdTmmzePHm

Yes, that is expected. $mpos is the reference for the current lexical value of mpos. I can see how it might be convenient for your example to have $mpos refer to the mpos from the outer lexical scope, but I think maintaining that $sym is always the reference for the current lexical value of sym is important for reasoning about more complicated cases.

(defui test-defui
  [{:keys [other-mpos]}]
  (ui/on
   :mouse-move
   (fn [_]
     (let [mpos other-mpos]
       [[::set-mouse-pos $mpos mpos]]))
   (ui/label "Hello mouse!")))

(ui/mouse-move (test-defui {:other-mpos 42}) [ 0 0])
;; ([:ui.membrane-ui/set-mouse-pos [(keypath :other-mpos) []] 42])

Ok good to know it is expected 🙂

I'm open to changes if there are good reasons, but that's the current rationale.

Or maybe figuring out how to add warnings or better error messages.

I think a warning would be nice if possible. It took me some time figuring out what was going wrong. And I don’t have a strong opinion yet on whether the current way is good or could be better.

Added this idea here, https://github.com/phronmophobic/membrane/discussions/66

contextual state lives under the :membrane.component/context key of the app state.

(defui sub-component
  [{:keys [x y text
           ^:membrane.component/contextual scale]}]
  (ui/on
   :mouse-down
   (fn [_]
     [[:set $scale 3.0]])
   (ui/translate x y
                 (ui/label (str text "-" scale)))))

(defeffect ::scale
  [$scale factor]
  (dispatch! :update $scale #(* % factor)))

(defui main-component
  [{:keys [^:membrane.component/contextual scale
           subs]}]
  (ui/on-key-press
   (fn [k]
     (case k
       "+"
       [[::scale $scale 1.01]]

       "-"
       [[::scale $scale 0.99]]

       []))

   (apply ui/scale scale scale
          (for [sub subs]
            (sub-component sub)))))

(skia/run (make-app #'main-component the-state) {:include-container-info true})

If you want it to live somewhere else, there are options, but it might depend on what you're trying to do.

Storing it under :membrane.component/context is fine, this works great, thanks!