Clojurians Log v2

It's ironic that https://potetm.com/devtalk/stability-by-design.html came out today. I'm sure there are good reasons for changing the signatures of parse and unparse, but for us it felt like "throwing wine glasses on the floor."

I feel you. The change was necessary to make unparse more usable, and to make parse return useful output even in weird situations. Some background in the tickets linked to the backlog.

i would trust the docs more than your LLM of choice, #reitit may be more interesting to you if you're looking at OpenAPI and associated architecture, and is also built to work well with malli

Thanks.

Did a little experiment with the ring-malli-swagger example in reitit and the answer was pretty clear:

WARNING: Unsupported schema for OpenAPI (expected :map schema) {:in :query} [:multi {:dispatch :type} [:sized [:map {:closed true} [:type :keyword] [:size [:int {:min 0}]]]] [:human [:map {:closed true} [:type :keyword] [:name [:string {:min 1}]]]]]

This was the route

["/multi"
        {:get {:summary "test multi schema"
               :parameters {:query [:multi {:dispatch :type}
                                    [:sized [:map [:type :keyword] [:size [:int {:min 0}]]]]
                                    [:human [:map [:type :keyword] [:name [:string {:min 1}]]]]]}
               :responses {200 {:body [:map [:message [:string {:min 1}]]]}}
               :handler (fn [_] {:status 200 :body {:message "OK"}})}}]

:multi gets converted to oneOf but you can't have a :multi for the :query parameters. Even OpenAPI can't express that: each query parameter is listed separately. The query parameters are wrapped into a malli :map just for convenience, it's not an actual map. Does that make sense?

here's the code: https://github.com/metosin/malli/blob/master/src/malli/json_schema.cljc#L125

we could probably have an example with a :multi ... I'll add one

https://github.com/metosin/reitit/pull/740

[:multi {:dispatch :type}
 [:literal [:map
            [:type [:= :literal]]
            [:value [:or :int :string]]]]
 [:reference [:map
              [:type [:= :reference]]
              [:description :string]
              [:ref :uuid]]]]

{"oneOf":[{"type":"object",
           "properties":{"type":{"const":"literal"},
                         "value":{"anyOf":[{"type":"integer"},{"type":"string"}]}},
           "required":["type","value"],
           "additionalProperties":false},       
          {"type":"object",
           "properties":{"type":{"const":"reference"},
                         "description":{"type":"string"},
                         "ref":{"type":"string","format":"uuid"}},
           "required":["type","description","ref"],
           "additionalProperties":false}]}}