an example to illustrate the issue:

(schema->malli {:type "string"})
;;=> string?

(= string? (schema->malli {:type "string"}))
;;=> false

(type (schema->malli {:type "string"}))
;;=> :malli.core/schema

(type string?)
;;=> clojure.core$string_QMARK___5475

Oh, I see, I can't call it at the end because it has to get the annotations of each json-schema property. Still, any suggestions for how to solve this? I suppose I could duplicate the expected pairs and modify the copy but it would be neat if I could reuse the existing one.

I've solved the false negatives by replacing (is (= schema (sut/schema->malli json-schema))) with (is (mu/equals (m/schema schema) (sut/schema->malli json-schema))) but now the diff isn't as nice 😞 I'm no longer blocked but I'd love to hear suggestions for improvements!

Yes, you should check the forms, not instances. Some suggestion: • would generate :string instead, I guess it contributes to better errors too • You can just say (is (= :string (m/form (sut/...)))) to get proper diffs

> would generate :string instead, I guess it contributes to better errors too > Great feedback, thanks! I'm kinda new to malli so I'm still cargo-culting my way, sorry, 😅 > You can just say (is (= :string (m/form (sut/...)))) to get proper diffs > This works for strings but there isn't a :pos-int, right? So I'm "stuck" with pos-int? which has the same issue. Or do you mean it should generate something like [:int {:min 1}] or [:and :int [:> 0]] instead? Not sure what the idioms are.