Fork me on GitHub
#malli
<
2021-02-26
>
borkdude10:02:26

Did this experiment. It brings malli to babashka via a pod. Due to pod limitations it might not bring you all the features, but might still be useful somehow. Feedback welcome 😊

bartuka19:02:11

not sure if ask in #malli or #reitit channel, but nesting routes with path params are not merged correctly. I found this issue https://github.com/metosin/reitit/issues/462 there is any update on this?

juhoteperi20:02:51

No updates yet. It is Reitit issue, Malli has malli.util/merge function that would work here, but Reitit doesn't have option to control how the values are merged, and because it is currently done using external library (https://github.com/weavejester/meta-merge) it is not simple to change. Might have to copy meta-merge logic to Reitit and extend with controls to use custom function in certain paths.

juhoteperi20:02:55

https://github.com/metosin/reitit/pull/474 adds tests and found the place where we could call malli merge

juhoteperi20:02:51

No updates yet. It is Reitit issue, Malli has malli.util/merge function that would work here, but Reitit doesn't have option to control how the values are merged, and because it is currently done using external library (https://github.com/weavejester/meta-merge) it is not simple to change. Might have to copy meta-merge logic to Reitit and extend with controls to use custom function in certain paths.

ikitommi20:02:28

there is also the nil-issue, that won't be fixed in meta-merge. Would simplify a lot how reitit route data can be used. metosin/ctrl-merge, right?