Fork me on GitHub
#malli
<
2019-11-05
>
plexus11:11:30

Seems there's an issue when using a custom registry with generate. The generators don't pass the opts down into m/schema, so when you have nested schemas they end up using the default registry

plexus11:11:36

or I'm holding it wrong 🙂 trying to come up with a minimal repro

ikitommi12:11:48

hmm… quick look says the sequential schemas are not passing the opts. PR welcome @plexus

ikitommi12:11:02

thanks, merged

plexus12:11:07

side note, is it too late to change childs to children?

plexus12:11:33

it bothers me every time 🙂

ikitommi12:11:59

* children - 8 700 000 000 hits * childs - 75 200 000 hits

ikitommi12:11:29

it’s pre-alpha, good time for fixing things like this. Do you have time for a PR?

ikitommi12:11:17

> The difficulty with the plural began in Old English, where the nominative plural was at first cild, identical with the singular, then c.975 a plural form cildru (genitive cildra) arose, probably for clarity’s sake, only to be re-pluraled late 12c. as children, which is thus a double plural. Middle English plural cildre survives in Lancashire dialect childer and in Childermas.

plexus12:11:50

interesting! wiktionary is a bit more harsh

plexus12:11:27

yeah, I can do a PR for that later today

👍 4
plexus12:11:56

I see I also broke some tests... will send a PR for that as well

plexus13:11:47

new PR sent. I really appreciate that the project has a bin/kaocha, it's so great not to have to think about how to run the tests on each project.

ikitommi14:11:04

thanks for the PR kaocha, makes things kinda simple 🙂