Fork me on GitHub
#lumo
<
2017-04-14
>
gmercer13:04:34

Seems to be a general reader error, being too eager to evaluate a regex. You can tickle this on the clojure side as well 馃檪 by putting a regex that is unacceptable to java.util.regex.Pattern in the :cljs regex e.g. \( without a matching close \)

anmonteiro14:04:11

@gmercer Regexes behave differently in the JVM and JS engines

pesterhazy17:04:45

just talked with @martinklepsch, he had a problem with installing lumo over npm (by way of unravel)

pesterhazy17:04:15

strangely he got a bin/lumo which invoked lumo.exe

pesterhazy17:04:53

so I'm guessing there he got the file for windows, even though he's on osx

anmonteiro17:04:17

we don鈥檛 mess with lein anywhere

pesterhazy17:04:17

uninstalling and reinstalling fixed it, so maybe some indeterministic problem?

pesterhazy17:04:43

I meant lumo, not lein

pesterhazy17:04:04

my brain stores words as "4-letter word starting with l"

pesterhazy17:04:54

anyway nothing major, but I suspect there's something that can go wrong in the download script

anmonteiro17:04:19

that worries me

anmonteiro17:04:23

here鈥檚 that logic

anmonteiro17:04:27

do you see anything wrong with it?

pesterhazy17:04:04

so bin/lumo defaults to the windows version

pesterhazy17:04:12

and gets overwritten by the platform-dependant one

anmonteiro17:04:43

so we could write bin/lumo (not lein 馃槀 ) as part of the installation script too

anmonteiro17:04:03

only for the Windows case, and if the download succeeds

anmonteiro17:04:16

PR welcome. if you don鈥檛 have time just open an issue, please

pesterhazy17:04:46

is npm ok with the bin script not existing in the source?

anmonteiro17:04:59

I don鈥檛 know

pesterhazy17:04:22

don't think I'll manage a PR as I don't have a windows box to test on

anmonteiro17:04:23

you can try it with npm install . inside the directory

pesterhazy17:04:34

but will make an attempt

anmonteiro17:04:49

I鈥檒l make sure to get to that before the next release

gmercer22:04:53

@anmonteiro I grokked the different regex languages per platform I was wondering why the reader was eager on resolving the regex, maybe it is difficult to skip over the characters in order to find all the :clj, :cljs or :cljr cases

gmercer23:04:53

I have one last issue in the instaparse .. again I am unsure this has anything to do with lumo (also happens in planck) regarding defonce and if