luminus 2018-01-01 | Slack Archive

yogthos16:01:35

you might want to take a look at this middleware https://github.com/joodie/ring-upload-progress/blob/master/src/ring/middleware/upload_progress.clj

donyorm17:01:39

I was looking at various issues and couldn't find where prone is enabled in the template by default. @yogthos do you know what file has those settings?

yogthos17:01:02

yeah it hides here https://github.com/luminus-framework/luminus-template/blob/master/resources/leiningen/new/luminus/core/env/dev/clj/dev_middleware.clj

yogthos20:01:20

@romain I updated the upload middleware to work with the latest Ring, let me know if it works for you https://github.com/luminus-framework/ring-upload-progress

romain23:01:07

Thanks, I will check it tomorrow

yogthos03:01:21

actually it looks like there's already an implementation in Ring core as well https://github.com/ring-clojure/ring/blob/eaf3af0449ad96b3f036a1ea9391af797e3654d9/ring-core/src/ring/middleware/multipart_params.clj#L19

yogthos03:01:45

it's also using Apache fileupload

yogthos03:01:48

looks like all you have to do is:

(wrap-defaults
      (-> site-defaults
          (assoc-in [:security :anti-forgery] false)
          (assoc-in [:params :multipart]
                    {:progress-fn
                     (fn [request bytes-read content-length item-count]
                       (println "bytes read:" bytes-read
                                "\ncontent length:" content-length
                                "\nitem count:" item-count))})))

yogthos04:01:11

added a full example https://github.com/luminus-framework/examples/tree/master/file-upload-progress

romain12:01:04

I don't know if I must admire you or fear you. I played with the example and it's great. Thanks for so much work!

romain13:01:22

I added the middleware in picture galery f example and I don't have console print. I miss something.

2018-01-01

Channels