Clojurians Log v2

1. I recall some past report where we came to the conclusion this doesn't work because clj-kondo drops the meta or something, needs to deep dive on this again

2. you need to include the meta properly so clj-kondo can emit those analysis, let me find an example

this is the less worst example I found:

(defn with-redefs
  "This transformation hook converts
   (state-flow.labs.state/with-redefs [bindings & flows])
   into
   (clojure.core/with-redefs bindings
     (state-flow.core/flow \"state-flow.labs.state/with-redefs\" flows))"
  [{:keys [node]}]
  (let [[bindings & flows] (rest (:children node))
        new-node (hooks/list-node
                  [(hooks/token-node 'clojure.core/with-redefs)
                   bindings
                   (hooks/list-node
                    (concat [(hooks/token-node 'state-flow.api/flow)
                             (hooks/string-node "state-flow.labs.state/with-redefs")]
                            flows))])]
    {:node (with-meta new-node (meta node))
     :defined-by 'state-flow.labs.state/with-redefs}))

ahhh okay, thank you

i can't get :defined-by to work but i'll keep playing around with it later

i spent more time on this and you’re correct that clj-kondo is dropping metadata from nodes returned by hooks

i can use :exclude-when-defined-by to not warn on unused vars, which is great

i still can’t navigate to the source of the macro, sadly

https://github.com/NoahTheDuke/lsp-repro

i pushed an example to that repo

i can create a github issue if you’ like one

hum please do, it will help me prioritize taking a closer look