Clojurians Log v2

This notices that clojure.string is in the require without an alias. When there's a use of the namespace in the code, clojure-lsp makes some suggestions for the alias and changes the :require and the expression

cool, looks good to me, go ahead!

Question about dep-graph/ns-aliases-for-langs: I'm calling it like this

(dep-graph/ns-aliases-for-langs db #{:clj})

(h/reset-components!)
    (h/load-code-and-locs "(ns )" "file:///xyz.cljs")
    (h/load-code-and-locs "(ns )" "file:///xyz.clj")
    (h/load-code-and-locs "(ns my.ns.b (:require [ :as xyz])))" "file:///b.clj")
    (h/load-code-and-locs "(ns my.ns.c (:require [ :as xyz])))" "file:///c.cljs")

(dep-graph/ns-aliases-for-langs db #{:clj})

#{{:alias xyz, :to , :usages-count 2}}

(get dep-graph ')

{:aliases {xyz 2},
 :aliases-breakdown {:external {}, :internal {xyz 2}},
 :dependencies {cljs.core 1, clojure.core 1},
 :dependents {my.ns.b 1, my.ns.c 1},
 :dependents-internal? true,
 :dependents-langs {:clj 1, :cljs 1},
 :internal? true,
 :uris #{"file:///xyz.clj" "file:///xyz.cljs"}}

(albeit a minor bug! 🐜 )

at this point, if there is no test for it, probably a bug, I already touched those things so many times in the past but always add a test to fix or ensure a behavior. one thing crossed my mind: how common is this? I mean, is it common to have a classpath with both cljs + clj and equal namespaces? I'm no cljs heavy user so not sure

I would imagine that it isn't common to have similar classpaths. I only happened across this when my tests failed on the count for cases when that happens. I'll see if I can fix it myself, but won't bother filing a github issue unless I can find the fix. (But maybe it would be worth documenting what's going on if it isn't fixed.)

I have a prototype to collect a per-alias-per-language count, but it does add one line to the data collection in dep-graph/update-usage to collect that extra data

(update-in [:dep-graph name :aliases-by-lang alias] f (first usage-langs))

at .lsp/config.edn more about it https://clojure-lsp.io/settings/#diagnostics-linter, seek for clojure-lsp/unused-public-var

Ah, perfect! Thanks.