Please do!
Has anyone tried using flowstorm to debug clojure-lsp? I'm using println and def to debug and feel like I'm dragging my knuckles, so I'm looking for something better. It seems like flowstorm should work, but before I try setting it up I figured I'd ask around.
I think some people used but I never got used to flowstorm workflow but I do think it's awesome for people that know how to use it.
Usually I just use lsp-clojure-nrepl-connect to get a repl to my running clojure-lsp and then eval stuff there
I was just looking into https://github.com/clojure-lsp/clojure-lsp/issues/2139 (Drop restriction on renaming unqualified keywords from @borkdude and @ericdallo). I suspect that the fix is trivial. I removed the check in rename/rename-status and clojure-lsp seems to rename unqualified keywords without any problem. However... the discussion in the bug was /why/ was it disabled.
I've noticed that with the restriction disabled, I can do dumb things like rename :require, :refer, and :as (from the ns macro) as well as the keyword :private in ^:private . Beyond keywords, clojure-lsp allows me to attempt to rename clojure core things like defn and let, but those LSP requests eventually fail. But, it lets me rename string/starts-with?, at least in my local files - fortunately it can't modify the files in clojure-1.12.2.jar.
As it stands, when I wanted to do this myself, I used the vscode global replace function. That does almost same thing as rename, with maybe slightly more downsides in that it not be syntax aware so could change comments, function names, etc... .
I don't know what the right thing to do is, but since the fix is so easy, I thought I might bring it up here to see what people think.
yeah, I think we should do it. Maybe having a internal denylist of kwds we should not allow renaming, but I'm pretty ok allowing this