lsp

2026-02-03T16:13:42.969289Z

Would there be interest in changing the hover/signature help info to wrap function definitions in parentheses? as it is right now vs as i'm suggesting

🔥 2
✅ 1
dharrigan 2026-02-03T16:21:21.157619Z

I think the latter looks more lispy 🙂

2026-02-03T16:21:33.206309Z

me too, which is why i'm asking

👍 1
dharrigan 2026-02-03T16:22:03.967649Z

I like it

ericdallo 2026-02-03T16:24:38.546189Z

I don't know, kinda of unnecessary 2 more chars (visual noisy)

ericdallo 2026-02-03T16:25:02.289329Z

in emacs for example looks pretty ok

ericdallo 2026-02-03T16:25:28.483319Z

I'd say for vim is more important to support the markdown render

seancorfield 2026-02-03T16:29:06.754209Z

Also bear in mind that doc does this (arglists wrapped in (..`)` but not the function):

➕ 1
2026-02-03T16:30:32.425339Z

i am not interested in mirroring doc, i'm interested in what makes the most sense for clojure-lsp

2026-02-03T16:31:56.362369Z

my feeling is that functions specifically are used in parentheses, so wrapping the doc in parentheses is a way to indicate both the type and the usage

2026-02-03T16:32:36.421919Z

but if eric doesn't like it, then never mind

ericdallo 2026-02-03T16:32:58.612989Z

let em check how it looks

ericdallo 2026-02-03T16:38:31.354779Z

How it looks in emacs at least:

ericdallo 2026-02-03T16:38:58.316179Z

I think I'm ok with that

ericdallo 2026-02-03T16:39:30.259789Z

seems that being more lispy helps understand what is that sym

👍 1
2026-02-03T16:39:45.777169Z

i can open a PR if you'd like

ericdallo 2026-02-03T16:41:50.739499Z

sure, just make sure to consider the case where we have the cursor in something that's not a call but we show the call:

👍 1
dharrigan 2026-02-03T17:06:14.019489Z

I like the parens, as it reads naturally for me, as I look at parens all day 🙂

ericdallo 2026-02-03T17:07:00.006639Z

Also it helps vim and other editors syntax highlight to consider as function

👍 1
2026-02-03T17:26:37.806769Z

i have semantics highlighting turned off and use treesitter for syntax highlighting, in case that matters

dharrigan 2026-02-03T17:31:12.025519Z

Is that :semantic-tokens? false in the config.edn file for clojure-lsp?

ericdallo 2026-02-03T17:51:35.272999Z

yes

ericdallo 2026-02-03T17:51:56.565379Z

but it seems trisitter considers that paren, you can see yours green with the change

2026-02-03T19:19:59.052659Z

what do you think?

2026-02-03T19:20:19.498559Z

ericdallo 2026-02-03T19:20:47.921589Z

Looks good!

2026-02-03T19:21:28.199769Z

2026-02-03T19:21:41.685599Z

cool, i'll open a PR!