lsp

seancorfield 2024-11-27T22:26:48.697739Z

@ericdallo Nightly builds of clojure-lsp have been failing for a while -- so the latest "nightly" available is November 14th, which means the latest clj-kondo available with that is September 28th. Anything we can do to help get the nightlies running again? Seems like timeouts running the JDK 8 part of the matrix?

ericdallo 2024-11-27T22:59:11.831549Z

Ah thanks, I'll take a look tomorrow, but jdk8 should not be a blocker

👍🏻 1
ericdallo 2024-12-02T12:35:23.080699Z

@seancorfield what made you think it's failing? the https://github.com/clojure-lsp/clojure-lsp-dev-builds/releases is really from nov 14

seancorfield 2024-12-02T17:14:55.926179Z

I sort of assumed "nightly" builds would happen any time any commits happened on the main branch and, in particular, this build failed that would have updated the version of clj-kondo being used:

ericdallo 2024-12-02T17:16:13.863849Z

yes, they happen in any commits. Those are unit tests failing because of JDK8 but they shouldn't affect nightly builds

ericdallo 2024-12-02T17:16:54.044879Z

the latest nightly is using kondo 2024.09.28-20241112.152908-13 , I need to bump to latest release yet

seancorfield 2024-12-02T17:18:55.482379Z

Ah, so this PR hasn't been merged yet https://github.com/clojure-lsp/clojure-lsp/pull/1917 -- 9/28 to 11/14 is a big jump, and since LSP was 11/14 I sort of expected the 11/14 kondo to be included... that's the root of my confusion...

ericdallo 2024-12-02T17:19:32.906239Z

yes, integration tests failed, I need to check if there is any breaking changes in kondo or something

ericdallo 2024-12-02T17:20:13.403869Z

it's not a big jump although the name suggests, it's a couple commits behind kondo latest release

seancorfield 2024-12-02T17:21:16.276829Z

I guess I was just unlucky that I tried to use a linter that is in the docs that was in the 11/14 kondo and thus not in the 11/14 LSP 🙂

ericdallo 2024-12-02T17:22:11.115029Z

yeah, I should bump that soon

1