lsp

bringe 2024-07-25T18:47:27.168009Z

Hi 👋. I've noticed that with Calva using clojure-lsp, and seemingly without me having updated the :ns-inner-blocks-indentation setting for clojure-lsp, using the clean ns form command causes the first require vector to be placed on the same line as :require, but it seems that https://clojure-lsp.io/settings/#clean`:next-line`. If I manually set the setting to :next-line, then the first require vector is placed on the next line as expected. Is clojure-lsp's default :next-line? If so, I'm wondering why it seems that by default the :same-line functionality is used. Clojure-lsp version: 1.11.1.1323 I want to make sure Calva's not doing anything to affect this, but I don't think that it is.

bringe 2024-07-25T18:48:45.105609Z

This is what happens without me setting a value for :ns-inner-blocks-indentation:

(ns example-ns
  (:require
   [clojure.alpha.spec :as s]))
Running clean-ns on this ns form should leave the form as it is according to the default, but instead the form gets formatted to the following:
(ns example-ns
  (:require [clojure.alpha.spec :as s]))

ericdallo 2024-07-25T18:50:19.823869Z

it seems https://github.com/BetterThanTomorrow/calva/blob/5ad8b28a41c2e56e7a7cea060d02d35d3da69da2/src/lsp/client/client.ts#L153s a deprecated old setting that does what ns-inner-blocks-indentation does

ericdallo 2024-07-25T18:51:00.442249Z

maybe we should remove that @brandon.ringe?

bringe 2024-07-25T19:14:18.512949Z

Ahhh thanks! @pez what are your thoughts? Is that okay to remove?

pez 2024-07-25T19:39:04.955019Z

Yeah. Makes sense to remove.

👍 1