lsp 2023-09-06 | Slack Archive

Noah Bogart13:09:14

I have a couple vars that shadow clojure.test function names (`testing` primarily), and if i try to use the code action to automatically add the import when i've written (testing ...), it only shows me Add require '[clojure.test :refer [testing]], even tho I have the file that defines my personal testing open in another tab and I know that LSP has cached its references. are these hardcoded? can that be relaxed?

Noah Bogart13:09:23

it looks like it should be selecting the right one, so i'm not sure what's happening

ericdallo13:09:23

hum, interesting, yeah, we have common-symbols pre-defined and we try to find there first https://github.com/clojure-lsp/clojure-lsp/blob/57d39a0c31b733f5c71d7f33265cad39e23bed6b/lib/src/clojure_lsp/feature/add_missing_libspec.clj#L458

ericdallo13:09:35

otherwise we fallback to check analysis

ericdallo13:09:07

but would be nice to support your case, I wonder if we can just always check the analysis since it's pretty consistent nowadays

👍 2

Noah Bogart13:09:30

I don't even mind it suggesting clojure.test, i'd just like it to suggest both, you know?

ericdallo13:09:06