weirdly it doesn't always do that, just on some forms

well actually interesting it doesn't even always happen on the same form 🤯

maybe throw away your elpa folder and re-install lsp-mode

this works fine now

(defn hello []
  42)

(def x 232)

yeah would do that after work, takes too long to reinstall everything

even though I'm pretty sure I had it for a while and I've done that already

You can check https://clojure-lsp.io/troubleshooting/#server-log to make sure it's not a server's fault before reinstalling everything

ah yes

2023-04-11T13:13:20.788Z  ERROR [clojure-lsp.server:55] - Error receiving message: Internal error (-32603)
{:id 1395, :method "textDocument/rangeFormatting"}
com.oracle.svm.core.posix.thread.PosixPlatformThreads.pthreadStartRoutine  PosixPlatformThreads.java:  203
            com.oracle.svm.core.thread.PlatformThreads.threadStartRoutine       PlatformThreads.java:  775
                            java.util.concurrent.ForkJoinWorkerThread.run  ForkJoinWorkerThread.java:  183
                              java.util.concurrent.ForkJoinPool.runWorker          ForkJoinPool.java: 1594
                                   java.util.concurrent.ForkJoinPool.scan          ForkJoinPool.java: 1656
                 java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec          ForkJoinPool.java: 1020
                                 java.util.concurrent.ForkJoinTask.doExec          ForkJoinTask.java:  290
                  java.util.concurrent.CompletableFuture$AsyncSupply.exec     CompletableFuture.java: 1692
                   java.util.concurrent.CompletableFuture$AsyncSupply.run     CompletableFuture.java: 1700
                                                promesa.util.Supplier/get                  util.cljc:   34
                                            promesa.exec/wrap-bindings/fn                  exec.cljc:  163
                                                 clojure-lsp.server/fn/fn                 server.clj:  291
                                    clojure-lsp.handlers/range-formatting               handlers.clj:  428
                              clojure-lsp.feature.format/range-formatting                 format.clj:  137
                                                     rewrite-clj.zip/node                   zip.cljc:  178
                                      rewrite-clj.custom-zipper.core/node                  core.cljc:   55
                                                         clojure.zip/node                    zip.clj:   67
java.lang.NullPointerException: 

feels like a classic zipper out of bounds NPE error

I'm on

clojure-lsp 2023.02.27-13.12.12
clj-kondo 2023.02.17

Should this be repro-able using clojure-lsp format?

yeah, weird I can't repro

clojure-lsp format will call the format whole buffer, probably won't repro that

that is only using range which is lsp-format-region

yeah clojure-lsp format works fine

@U0524T275 would help if you get client<->server logs and check what client is sending to server to range format

actually one think I didn't mention is that I selected the form before pressing TAB for the formatting

if I just do TAB before the form on (def x 3) without selecting anything it works

yeah, that's one of the things I tried as well

but well actually it's not even deterministic

since sometimes it just works

yeah, that make things harder to debug

most of the times it works tbf

I'll check that it's not my Emacs config somehow after work

I just nuked my elpa directory, reinstall everything and it still does the same

I'll see if it I can replicate it somehow with a minimal config

I really can't find any pattern in when it happens or useful log

I'll just disable the lsp indentation for now I guess until I find out

$ clj-kondo --lint src
linting took 57ms, errors: 0, warnings: 0

I didn't know about that kondo config, could you elaborate what you would expect from clojure-lsp? is your problem with clojure-lsp CLI or editor?

Interestingly:

$ clojure-lsp-dev diagnostics
[100%] Project analyzed
Finding diagnostics...
Execution error (NullPointerException) at java.util.regex.Matcher/getTextLength (Matcher.java:1769).
Cannot invoke "java.lang.CharSequence.length()" because "this.text" is null

Full report at:
/var/folders/j9/xmjlcym958b1fr0npsp9msvh0000gn/T/clojure-6415229798231618710.edn

My expectation is that clj-kondo config is not tampered with and it just lints the features that I describe in my config.edn

I'll update clojure-lsp from master, maybe it helps

no, same NPE

[[java.util.regex.Matcher getTextLength "Matcher.java" 1769]
   [java.util.regex.Matcher reset "Matcher.java" 415]
   [java.util.regex.Matcher <init> "Matcher.java" 252]
   [java.util.regex.Pattern matcher "Pattern.java" 1149]
   [java.util.regex.Pattern split "Pattern.java" 1277]
   [java.util.regex.Pattern split "Pattern.java" 1350]
   [clojure.string$split invokeStatic "string.clj" 225]
   [clojure.string$split invoke "string.clj" 219]
   [clojure_lsp.feature.diagnostics$kondo_findings__GT_diagnostics$fn__18370
    invoke
    "diagnostics.clj"
    123]
   [clojure.lang.Delay deref "Delay.java" 42]
   [clojure.core$deref invokeStatic "core.clj" 2337]
   [clojure.core$deref invoke "core.clj" 2323]
   [clojure_lsp.feature.diagnostics$diagnostics_start_char_coll_QMARK_
    invokeStatic
    "diagnostics.clj"

When I do:

(defn ^:private kondo-findings->diagnostics [uri linter db]
  (let [range-type (settings/get db [:diagnostics :range-type] :full)
        ;; we delay for performance
        lines* (delay (some-> (get-in db [:documents uri :text])
                              (string/split #"\r?\n")))]
    (when-not (exclude-ns? uri linter db)
      (->> (get-in db [:findings uri])
           (filter valid-finding?)
           (mapv (partial kondo-finding->diagnostic range-type lines*))))))

and then the diagnostics are accurate

Ah I think it was the wrong project root for this project

now it works

but maybe it's good to keep the some->?

ah yeah, that was a recent change related to the squiggles from your other issue, change to some-> makes sense

ok, please make the edit on master yourself, too small for a PR + test probably

sure, thanks

thank you!

do you want to practice your talk this week?

I need to create it first 😂 I'm kind of late