I just made that lsp4clj release and made a commit bumping to that release yesterday

I tagged but forgot to push to clojars, will do in a few minutes

I noticed the latest version on clojars was 1.7.1

yeah, 1.7.2 was a simple fix that I forgot as well, that's why there is a https://github.com/clojure-lsp/lsp4clj/issues/4 😅

I'll bring this to Nubank to check if there are people interested starting coding in OSS projects, and that's a nice good first PR

Just pushed to clojars 1.7.3

thanks, I'll follow up with a JDK 19 fix

I still run clojure-lsp from source but now use GraalVM JDK19 by default

Cool!

@ericdallo whoops, with the latest commit I introduced a cyclic dependency:

Cyclic load dependency: [ /clojure_lsp/internal_api ]->/clojure_lsp/handlers->[ /clojure_lsp/internal_api ]->/clojure_lsp/main

Any other good place to add helper functions?

shared.clj?

Usually shared

ok done

lib/src/clojure_lsp/internal_api.clj is not like clj-kondo impl core hehe, internal_api is the ns only accessed by CLI/API, not editor

@U04V15CAJ why warn-on-reflection doesn't catch that kind of reflection issue?

it does, but only on JDK 19

since they added another overload in Thread

I see, I think I'd prefer to not have that shared function and have a CI for jdk19 WDYT?

having the shared function will avoid making this mistake

yeah, but if we have the CI we could avoid that without needing a shared function right?

just to avoid more things to shared

for simpler things

fine with me

does ci catch reflection issues?

Good question, if not it should probably

I recently made a test for it myself for a native image project: https://github.com/borkdude/http-kit/blob/c37f7795a18e88d7eecba0026a7eee77ae51359a/test-native/bb.edn#L15-L18

I can port that to clojure-lsp as well

looks good, I can't see that working only with static checks indeed (besides eastwood)

do you run eastwood on lsp?

nope

ok, then I'll port the reflection test?

would be great!

ok, later today

thanks, https://github.com/clojure-lsp/clojure-lsp/blob/master/bb.edn#L31-L37 is how we do all kinds of test ATM

cool. why is lsp4clj a bb dep?

does it run in bb? ;)

btw I think you can remove https://github.com/clojure-lsp/clojure-lsp/blob/a10181068eeead05cfa761b0847a7fb9601a703a/bb.edn#L9 now, spec is bundled in bb already

ah cool! for integration-test we heavily use ls4clj so it's bb compatible I think :)

wow ok :)

@U04V15CAJ I opened https://github.com/clj-kondo/clj-kondo/pull/2008 and https://github.com/clojure-lsp/clojure-lsp/pull/1521 with a initial implementation after our discussions about ASM, LMK what you think :)

pretty cool!