whenever im trying to do a textDocument/hover in my nvim i get this error now:

clojure_lsp: -32603: Internal error

dont see anything useful in the client side lsp logs

Yeah, I'm working on that, it's a bug, I'm using eval and graal doesn't support that

will do a hotfix

ah, thanks!

tried it with the dev build here: https://cirrus-ci.com/task/6733629292806144 and it works!

thanks! 😄

thanks for testing!

released the fix https://github.com/clojure-lsp/clojure-lsp/releases/tag/2023.02.27-13.12.12

🎉

com.oracle.svm.core.posix.thread.PosixPlatformThreads.pthreadStartRoutine  PosixPlatformThreads.java:  203
            com.oracle.svm.core.thread.PlatformThreads.threadStartRoutine       PlatformThreads.java:  775
                                                     java.lang.Thread.run                Thread.java:  829
                       java.util.concurrent.ThreadPoolExecutor$Worker.run    ThreadPoolExecutor.java:  628
                        java.util.concurrent.ThreadPoolExecutor.runWorker    ThreadPoolExecutor.java: 1128
                                      java.util.concurrent.FutureTask.run            FutureTask.java:  264
                                                                      ...                                 
                                      clojure.core/binding-conveyor-fn/fn                   core.clj: 2047
                             clojure-lsp.startup/analyze-source-paths!/fn                startup.clj:   73
                                    clojure-lsp.kondo/run-kondo-on-paths!                  kondo.clj:  328
                                             clojure-lsp.kondo/run-kondo!                  kondo.clj:  312
                                          clojure-lsp.kondo/run-kondo!/fn                  kondo.clj:  313
                                                      clj-kondo.core/run!                   core.clj:  224
                                                   clj-kondo.core/run!/fn                   core.clj:  225
                                 clojure-lsp.kondo/run-kondo-on-paths!/fn                  kondo.clj:  325
                                   clojure-lsp.kondo/custom-lint-project!                  kondo.clj:  213
                     clojure-lsp.feature.diagnostics/custom-lint-project!            diagnostics.clj:  230
                      clojure-lsp.feature.diagnostics/findings-of-project            diagnostics.clj:  215
                       clojure-lsp.feature.diagnostics/unused-public-vars            diagnostics.clj:  188
                                                         clojure.core/set                   core.clj: 4114
                                                     clojure.core/reduce1                   core.clj:  944
                                                  clojure.core/chunk-next                   core.clj:  710
                                                                      ...                                 
                                                      clojure.core/map/fn                   core.clj: 2763
                                                         clojure.core/seq                   core.clj:  139
                                                                      ...                                 
                                                   clojure.core/filter/fn                   core.clj: 2834
                                               clojure.core/complement/fn                   core.clj: 1455
                                                  clojure.core/partial/fn                   core.clj: 2648
    clojure-lsp.feature.diagnostics/exclude-public-diagnostic-definition?            diagnostics.clj:   65
                                              clojure.string/starts-with?                 string.clj:  365
java.lang.NullPointerException: 

and then this appears constantly:

2023-02-27T16:25:22.309Z  WARN [clojure-lsp.kondo:315] - Non-fatal error from clj-kondo: No configs copied.

and then all navigation just reports no definition found for …

Maybe it helps to disable the unused public var linter ;)

only on latest release @U11BV7MTK?

yes. was previously working fine. i’m gonna try to disable the linter and see if that fixes it. and then rollback with linter enabled and should continue working?

the exception happens https://github.com/clojure-lsp/clojure-lsp/blob/148222e32dedc5be06e02faee9e13c4dd77d7251/lib/src/clojure_lsp/feature/diagnostics.clj#L65, weird, some var-definition is missing a :name , we didn't change anything related to that in clojure-lsp IIRC

i still get the error with the linter disabled

clojure-lsp.feature.diagnostics/exclude-public-diagnostic-definition?            diagnostics.clj:   65
                                              clojure.string/starts-with?                 string.clj:  365

Hmm, probably also an opportunity for performance, when people don't use the linter don't do the work?

we do have this check https://github.com/clojure-lsp/clojure-lsp/blob/148222e32dedc5be06e02faee9e13c4dd77d7251/lib/src/clojure_lsp/kondo.clj#L209

Downgrading to 2022.12.09-15.51.10 fixes navigation. Interestingly I’m seeing a bunch of

ARNING: error while trying to read hook for clojure.test/deftest: Unmatched delimiter: ), expected: ] to match [ at [11 10]

oh so, even the release of jan happens the same issue? https://github.com/clojure-lsp/clojure-lsp/releases/tag/2023.01.26-11.08.16

that warning is probably not related

@U11BV7MTK could you confirm the issue happens on jan release as well? there was indeed code changes in that release

checking

would be nice if I can repro that, is that metabase?

issue not present on the link you sent for the jan release. no error in startup log. Yes it is metabase

thanks, will try it myself and let you know

Found it, maybe it's a bug on clj-kondo The exception when analyzing defclause https://github.com/metabase/metabase/blob/07f174deaaf3ee7794e17c3aa9ebf94250b04d8e/shared/src/metabase/mbql/schema.cljc#L986, this is a analysis with the name nil which AFAIK should not happen:

{:end-row 984,
 :meta {},
 :name-end-col 82,
 :external? false,
 :name-end-row 983,
 :name-row 983,
 :ns metabase.mbql.schema,
 :name nil,
 :lang :clj,
 :col 1,
 :name-col 70,
 :uri "file:///home/greg/dev/metabase/shared/src/metabase/mbql/schema.cljc",
 :end-col 44,
 :bucket :var-definitions,
 :row 983}

I noticed that macro is configured as a lint-as in clj-kondo config clj-kondo.lint-as/def-catch-all

is this configured with def-catch-all, this had a change recently in clj-kondo which should have been an improvement ;)

the improvement was that locations were added

I don't recall removing the name though ;)

@U11BV7MTK would you mind creating that issue in clj-kondo later with those details of that macro please?

can you reproduce the issue with clj-kondo only? the analysis of the defclause defined vars should have a name

borkdude@m1 ~/temp/lint_as $ clj-kondo --lint src/my_lib.clj --config '{:analysis true :output {:format :edn}}' | jet -t ':analysis :var-definitions'
[{:col 1,
  :defined-by clojure.core/defmacro,
  :end-col 31,
  :end-row 3,
  :filename "src/my_lib.clj",
  :macro true,
  :name defclause,
  :name-col 11,
  :name-end-col 20,
  :name-end-row 3,
  :name-row 3,
  :ns my-lib,
  :row 3,
  :varargs-min-arity 0}
 {:col 1,
  :end-col 44,
  :end-row 6,
  :filename "src/my_lib.clj",
  :name median,
  :name-col 62,
  :name-end-col 68,
  :name-end-row 5,
  :name-row 5,
  :ns my-lib,
  :row 5}]

(ns my-lib)

(defmacro defclause [& _args])

(defclause ^{:requires-features #{:percentile-aggregations}} median
  field-or-expression FieldOrExpressionDef)

{:lint-as {my-lib/defclause clj-kondo.lint-as/def-catch-all}}

sorry just out of a meeting. Is that a sufficient repro? Or shall i make an issue?

This isn't a repro: it shows the name is there so it's more of a counter-repro

But if you can provide a repro in the above format, that would be sweet

thank you for reporting this @U11BV7MTK

having trouble identifying any blank names on my side

clj-kondo/clj-kondo          {:mvn/version "2023.02.17"}

(def x (clj-kondo/run! {:lint ["src"]
                          :config {:analysis true
                                   :output {:format :edn}}
                          :config-dir ".clj-kondo"}))

kondo=> (count (->> x :analysis :var-definitions (filter (comp nil? :name))))
0

yeah, I suspect it's something with that ns or any extra kondo config that metabase does differently

ah, i didn’t have that classpath root

kondo=> (->> x :analysis :var-definitions (filter (comp nil? :name)))
({:end-row 984,
  :name-end-col 82,
  :name-end-row 983,
  :name-row 983,
  :ns metabase.mbql.schema,
  :name nil,
  :lang :clj,
  :filename "shared/src/metabase/mbql/schema.cljc",
  :col 1,
  :name-col 70,
  :end-col 44,
  :row 983}
 {:end-row 984,
  :name-end-col 82,
  :name-end-row 983,
  :name-row 983,
  :ns metabase.mbql.schema,
  :name nil,
  :lang :cljs,
  :filename "shared/src/metabase/mbql/schema.cljc",
  :col 1,
  :name-col 70,
  :end-col 44,
  :row 983})

and what is at the location at the source? e.g. can you narrow the repro down to only that source snippet?

(declare ag:var) ;; for clj-kondo
(defclause ^{:requires-features #{:standard-deviation-aggregations}} [ag:var var]
  field-or-expression FieldOrExpressionDef)

ag:var looks suspicious

but repro finds it:

❯ echo '(declare ag:var)' | clj-kondo --config '{:analysis true :output {:format :edn}}' --lint - | jet -t ':analysis :var-definitions'
[{:col 1,
  :defined-by clojure.core/declare,
  :end-col 17,
  :end-row 1,
  :filename "<stdin>",
  :name ag:var,
  :name-col 10,
  :name-end-col 16,
  :name-end-row 1,
  :name-row 1,
  :ns user,
  :row 1}]

I can repro the issue with @U04V15CAJ’s repro but with this code:

(defclause ^{:requires-features #{:standard-deviation-aggregations}} [ag:var var]
  field-or-expression FieldOrExpressionDef)

def-catch-all expects a symbol at that location

with custom syntax like this, it might be better to write a hook (:macroexpand hook is easiest and sufficient for this one probably)

ah right. i’m linting the wrong line

i got confused by the two results thinking it was the two forms. but it’s from clj and cljs analysis

looks like the previous kondo (“2023.01.16”) also reported a nil name

{:filename "shared/src/metabase/mbql/schema.cljc",
  :row nil,
  :col nil,
  :ns metabase.mbql.schema,
  :name nil,
  :lang :clj}

{:end-row 984,
  :name-end-col 82,
  :name-end-row 983,
  :name-row 983,
  :ns metabase.mbql.schema,
  :name nil,
  :lang :clj,
  :filename "shared/src/metabase/mbql/schema.cljc",
  :col 1,
  :name-col 70,
  :end-col 44,
  :row 983}

yes, I think clojure-lsp skips things with nil locations

but it should probably skip things with nil names ;)

yeah, it never occurred that could come nil from kondo, maybe we should

clj-kondo could also not include this nil-name var, but then it would maybe also harder to debug things

Yeah, I think so

it’s interesting it knows the length of the name (70 - 82) but doesn’t grab the name

because it's the length of the vector, but [ag:var var] it's not really a name of a var-definition

I think it does (:value node) which normally returns the symbol

but in the case of a vector node it's nil

Ah. Right. I was focusing on the colon in the name. But the vector doesn’t make sense at all. Sorry I’m playing catch-up on that

have we arrived at a conclusion? will it be fixed? 😅

AFAICS it should be fixed in metabase repo itself, defining a hook for that macro

@U11BV7MTK Happy to do that later this week, if you want me to do it

I agree that there should be a fix in metabase. But seems lsp/kondo should be more resilient and not fail?

yes, we should filter nameless var-definitions in clojure-lsp or kondo, I'm ok doing it on clojure-lsp so feel free to open an issue there

maybe we should submit a PR to clojure to not NPE on string functions :P

😂

ok, so i need to debug why my personal setup broke with the latest release from first principles, gotcha

if it’s the same stacktrace as I was seeing,

(ns nocommit.kondo
  (:require [clj-kondo.core :as clj-kondo]
            [clojure.string :as str]))

  (def x (clj-kondo/run! {:lint ["src"
                                 ;; and your other source paths
                                 ]
                          :config {:analysis true
                                   :output {:format :edn}}
                          :config-dir ".clj-kondo"}))

(count (->> x :analysis :var-definitions (filter (comp nil? :name))))

https://github.com/clojure-lsp/clojure-lsp/issues/1510 in clojure-lsp. Thank you all for the help