Fork me on GitHub
#lsp
<
2023-01-07
>
Matthew Odendahl00:01:45

lsp-clojure-move-form isn't working right. It doesn't add references the moved form needs to the destination namespace.

Matthew Odendahl00:01:48

https://github.com/clojure-emacs/clj-refactor.el (a CIDER addition) does this part properly. (Unfortunately, it's even more broken in other ways.)

ericdallo00:01:59

that's a complex feature to implement, it's a work in progress currently with known missing parts: https://github.com/clojure-lsp/clojure-lsp/issues/566

👀 2
ericdallo00:01:07

the main issue is the need to handle multiple corner cases as mentioned in the issue and PR

Matthew Odendahl01:01:22

It is better than doing everything by hand, but correcting the problems gets tedious. I'll read through those and see if I've noticed any edge cases not mentioned.

ericdallo01:01:10

that would help, thanks! I intend to take a closer look at this issue in the future, the way to make that work if know every possible case and we can implement one by one