Could you share a test example?

(require '[cljest.core :refer [describe it]])

(describe "foo"
  (it "returns bar"
    (m/=? "bar" (foo))))

Maybe try teaching clj-kondo to lint that describe as a var

{:lint-as cljest.core/describe clojure.test/deftest}

In your . clj-kondo/config.edn

still treats it as a reference

(defn test-reference? [source-path {:keys [filename]}]
  (and source-path
       (not (string/starts-with? filename source-path))
       (string/includes? filename "_test.")))

I think this is used to split them up. We use _spec prefix. I guess that’s why they don’t show up.

yep, you are right

is _spec prefix a standard for cljest?

it doesn’t need to be

and we haven’t open sourced it yet

we are just using it cos we have karma tests with _test prefix 😄

yeah, we could make it configurable I think with a default value of ["_test"]

renaming to *_test, doesn’t help so I think it’s also something to do with classpath

hum, that function is only testing if: • the current var you are seeing references lens, is not in the test source-path of the usage (e.g. we only show that a var has test references if the var is on src and the test in another source-path like test) • the test reference filename has a _test in its filename • source-paths are properly configured (check lsp-clojure-server-info)

so we have spec files next to the normal files

eg src/a.cljs, and src/a_spec.cljs

yeah, that's a blocker ATM

if we can think on some kind of config generic that would work for most users and you we can create a issue

This is something on the LSP spec, the client can ask for a references to include it's definition, there is a lsp-mode var for that IIRC

from lsp-mode code:

(cl-defun lsp-find-references (&optional include-declaration &key display-action)
  "Find references of the symbol under point."
  (interactive "P")
  (lsp-find-locations "textDocument/references"
                      (list :context `(:includeDeclaration ,(lsp-json-bool include-declaration)))
                      :display-action display-action
                      :references? t))

could you try lsp-find-references instead?

lsp-find-references behaves in the same way

what's your clojure-lsp version?

❯ clojure-lsp --version
clojure-lsp 2022.07.24-18.25.43
clj-kondo 2022.06.23-SNAPSHOT

Hum, we didn't change anything on clojure-lsp recently related to that and it's working properly to me, so I guess it's something on lsp-mode/your config, not sure what though

Strange. I’m pretty sure it was working for me until very recently, and I don’t think I’ve changed anything related either.

Oh, it’s in the CHANGELOG for 8.0.1: lsp-find-references to include declaration by default

Oh, I was not aware of that :)

https://github.com/emacs-lsp/lsp-mode/commit/2c6a0e92402708780f18745f98ca128be64bbc78

I suggest you ask on Emacs-lsp discord why the change and how to change to the previous one

Okay, will do. It doesn’t look configurable, so I guess I need to make a wrapper to pass in the parameter

yeah, a variable for that would make total sense, you could open a PR if you have the time :)

:thumbsup: