Fork me on GitHub
#lsp
<
2022-06-27
>
Panel04:06:46

I often use libs with the ful name when experimenting, example : clojure.string/split Can lsp help refactoring those into proper require ?

ericdallo12:06:35

yes, it present a code action to add the require as string

👍 1
robert-stuttaford05:06:55

just confirming that the ARM version isn't available via homebrew yet?

borkdude07:06:51

There needs to be a new release of clojure-lsp since the package is updated via CI

ericdallo12:06:09

Oh, can't we fix it without a release?

ericdallo12:06:41

I thought things were already working for m1 as we manually added the zip file to it and all files were changed

borkdude13:06:46

@UKFSJSM38 As you know yourself, the brew recipe is updated on release and it uses the assets in github actions during the release. This is a bit brittle since this only allows you to update the brew formula when you trigger a release.

borkdude13:06:52

Of course this could be rewritten to a cron job on github actions in the formula repo which updates that repo like every day or so or on demand when you trigger it. And/or a script that you can just run locally to update the formula.

borkdude13:06:03

That seems like a more flexible way to do things

borkdude13:06:23

But I haven't touched that since that would be a bigger change

ericdallo13:06:09

oh, got it, I think I can manually trigger the recipe update

ericdallo13:06:17

I did that few times already

robert-stuttaford06:06:11

apologies for being a total pest here @UKFSJSM38 - are you likely to update the brew recipes soon? otherwise i'll just manually install the GH release so long 🙂

borkdude06:06:09

Also the install script still needs to be updated btw: https://github.com/clojure-lsp/clojure-lsp/blob/13e78e3af8082780ebab21a21166ad9598c27562/install#L87 uname -m returns arm64 on macos m1 I can change that in a PR if you want

borkdude06:06:46

Lemme try that now

borkdude06:06:51

@U0509NKGK

curl -s  > /tmp/clojure-lsp-install

chmod +x /tmp/clojure-lsp-install
/tmp/clojure-lsp-install --dir /tmp