Seems like a bug in clj-kondo? I would expect case-insensitive sorting.

It's not a bug, always been like this, there is no such thing as case insensitive sorting in clj-kondo.

Note that clojure-sort-ns is consistent here

I'll take a look soon

To be honest I was not aware of that clj-kondo linter, I'll enable for clojure-lsp repo to help with those kind of issues

I always enable it in my home config

it'd be nice to have it enabled as default, but It would probably cause lots of headaches for most users

yes

@U04V15CAJ I found we already have a setting for that:

:clean {:sort {:require :lexicographically}}

I wonder why it's not default/if it will cause any other undesired harm

if not, we should make it default

c/c @U0BUV7XSA

it is the default of tooling prior to clojure-lsp, like clojure-sort-ns which is why clj-kondo warns about it like this. having multiple options just creates more confusion imo

I agree, if this setting changes only this behavior, I'm ok changing it, but if causes any other behavior that should not be default we need to think more about it

I'll take a closer look, but I think this setting can break other cases

we only had it lexicographic originally, not sure why it wasnt kept as default.

we have https://github.com/clojure-lsp/clojure-lsp/blob/master/lib/src/clojure_lsp/feature/clean_ns.clj#L71-L85, which sorts differently, we need to check if we need to change anything with lexicographic or it will behave ok

I think I have a quick fix for that

@U0BUV7XSA we were already trying to make sorting lexicographically as default, but not right 😅 , I'll fix it to be lexicographically not needing the lexicographically setting anymore

What is the proper way to sort this?

(ns foo.bar
  (:require
   ["foo.bar" :default Foo]
   [ball import1]
   [zebra]
   apple
   ball))

(ns foo.bar
  (:require
   ["foo.bar" :default Foo]
   apple
   ball
   [ball import1]
   [zebra]))

if you agree kondo is right, I can change that behavior @U0BUV7XSA it's just that it has a test testing that way

top looks right to me.

@ericdallo strings go first lexicographically, for the dumb reason that " is before a but surrounding vectors are ignored

[ goes first though

yeah, kondo doesn't like [ first

again, clj-kondo respects how other tools always did it and it didn't want to cause any friction with those: clj-kondo only warns, other tools fix (clojure-sort-ns)

and clojure-sort-ns ignores the vector around the names

yeah, I agree with other tools

is it ok for you to change to follow other tools standard @U0BUV7XSA?

cursive just had sort lines for the longest time (still?) if you sort lines you end up with the top

clojure-lsp issue i raised about this: https://github.com/clojure-lsp/clojure-lsp/issues/561

vim too. i think they are different sorts.

Well remembered @U11BV7MTK, so I think we have 2 differents sorts indeed, but kondo (our main linter) has a preference

so we should at least change the default to match kondo I guess? or change kondo to match current clojure-lsp one

I actually don't care that much which we choose, but if people fix it up with some other tool which then causes lint warnings, that is mostly what I want to prevent

and clojure-sort-ns was the tool I was using myself for this (and many other people)

yeah, for example, if we go with current kondo uses, cursive may complain about it

but nobody in cursive is using clojure-lsp

they do on cli tho

yes, cursive users may not use on editor, but all nubank projects have clojure-lsp as cli tool on CI for example

ok that sucks then :)

yeah, we need to think on the best default

what tool other than clojure-sort-ns uses this sort?

maybe we should have something on https://github.com/bbatsov/clojure-style-guide 😅

I think we can prevent the [] discussion by saying: always wrap your ns name in a vector, as the default style

then there's the case insensitivity: I'm open to making this the default in clj-kondo or at least make clj-kondo not complain about either way

so, should we have kondo saying that instead of "sort your requires"?

not instead

does kondo lint other style guide rules? is this one on by default?

this one is not on by default but I use it in my home config, so I have it on by default in any project

we could turn the [foo] vs foo linter on if you have the sorting linter enabled

or just advice that when people complain ;)

and put it into the docs

so should we change anything on clojure-lsp side? We had https://github.com/clojure-lsp/clojure-lsp/issues/561 to on purpose ignore case in sorting

I'll just make clj-kondo more lenient with case sensitivity then I guess and if people complain, we can make an option to make it more strict again

Now I see why this linter is not enabled by default 😂 lots of different opinions. I still think it should have something mentioning that on ClojureStyleGuide or something

I've made the linter lenient before, it should probably only warn on things that are unarguably not sorted by a very broad collection of opinions 🤷

https://github.com/clojure-emacs/clojure-mode/issues/409#issuecomment-247744974 interesting comment here.

I've had requests to support custom sorting "opinions" in clj-kondo, but I refused since I think we have enough discussion on indentation in the community already ;)

Btw, one more thing. Often scripts or clerk notebooks have this:

(require '[nextjournal.clerk :as clerk]
         '[babashka.fs :as fs])

You mean that clojure-lsp ignore requires not inside a ns form?

yes

it's not super common, but it does happen

Alright, please open a issue, I think we should support that somehow

low priority

https://github.com/clojure-lsp/clojure-lsp/issues/1047

Thanks!

Pushed to master (case insensitivity)

I will do a release probably tomorrow

No hurry. I want to get in some more stuff on Wednesday and might release a new clj-kondo then

Actually the only thing left for me to do is make an macos aarch64 binary and then I'm good to go

Right, I think I'll wait for you, we have lots of change so clojure-lsp, that's why I wanted to do a release

OK, there's also one more linter coming up: discouraged ns 😈 by @U04V4KLKC

I'll ping you when clj-kondo is ready then on Wednesday

You mean that there is the same ns both in the project and in the classpath as a git lib dep?

I don't know why it would be on the classpath - it doesn't appear when I do clojure -Spath

Hum, could you add dev:test profiles to that command? clojure-lsp uses it as default aliases

still not

Hum, what file/line/col you are seeing that behavior so I can test it later?

in nextjournal/clerk.clj 264:68