Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2022-05-26

Channels

#lsp
<
2022-05-26
>
borkdude08:05:51

I noticed renaming of a deftype doesn't really work in clojure-lsp

ericdallo12:05:45

Hum, I can take a look soon, but it may be related with deftype be a protocol-impl and not a var-def, but we probably can fix on LSP side

borkdude12:05:19

not a big issue, I don't rename deftypes that often :)

👍 1
sheluchin12:05:41

Would it make sense to add a refactoring for namespaced map <-> map without default namespace (not sure if there is a name to distinguish this)? Like #:foo{:bar 1} <-> {:foo/bar 1}?

➕ 1
ericdallo12:05:31

I think so, seems valid

ericdallo12:05:38

Feel free to open a issue with details

sheluchin12:05:38

@UKFSJSM38 Thanks, will do. I haven't done a dive to figure out how to contribute such features yet. Is posting issues like this helpful to the project? Want to make sure I'm not creating unnecessary noise 🙂

ericdallo12:05:09

Sure, issues are welcome and help tracking efforts

ericdallo12:05:40

We can discuss the impl details and what the feature would be in the end there as well

sheluchin12:05:48

Great. Will do. Thanks very much.

lread14:05:19

Renaming namespaces is awesome! Renames/moves the source file, updates references. That was you right, lsp? Thanks!

🙌 3
ericdallo14:05:08

Yes! thank you!

🙌 1
borkdude14:05:31

Yes, hail lsp!

🙌 3
Noah Bogart14:05:55

maybe bug report, maybe configuration issue with my set up: when I trigger signature help, it doesn't update the position of the current parameter (or active signature) when I'm between parameters: (filter even? |) acts as if I'm still inputting the predicate

Noah Bogart14:05:11

if I put in another character, it selects the next signature and the next parameter, but I would expect/like it to select those when I've input a space, as that's categorically moving on from the previous signature

ericdallo15:05:58

yeah, it's a "expected" behavior on clojure-lsp side, the issue is: we parse the code with rewrite-clj and we would need to know when to know user is trying to add a new arg

ericdallo15:05:19

not sure we could assume a space + cursor on that position should show a next arg, maybe yes

👆 1
Noah Bogart15:05:25

cool, as long as it's expected behavior I won't sweat it too much. I'd prefer it to assume I'm on the next arg but that's pretty small

ericdallo15:05:00

yeah, to be honest when I implemented that I didn't spend that much time thinking on that, you can file a issue and check what other users think about too

👍 1