hum, I think that was intentional, looks like vim has a different behavior, @U07M2C8TT knows more about that feature

@U0BUV7XSA that’s an accident and your proposed fix looks good. Thanks for tracking that down

And yes, the intent is to maintain position, not to select a range

This is one of the features I've wanted since the beginning. Great job.

Thanks! It was a fun introduction to clojure-lsp development. Now I’m addicted. :)

> If I ask for the code actions with the point in that position What position exactly?

after the last s ?

well, clojure-lsp should provide that in any place of that line, you should see the code action to add the require even not inside that paren, if in the same line

Yeap. After the last s

what code actions are available for that line?

what's your clojure-lsp --version?

Oh, okay, I remember this issue. Maybe it’s eglot’s fault?

If the point is not above the chars marked by flymake, I get those actions:

Move to let
Cycle privacy
Clean namespace
Thread last all
Extract function
Thread first all
Move coll entry up
Move coll entry down
Create test for 'clojure-service-request?'

> clojure-lsp should provide that in any place of that line out of curiosity, if there were two possible additions of requires, what would be the expected behaviour if I ask for code actions in a position that is not over any of them?

> out of curiosity, if there were two possible additions of requires, what would be the expected behaviour if I ask for code actions in a position that is not over any of them? do you have a example? it's not clear to me

(str/foo a b) (+ 1 2|) 

> do you have a example? it’s not clear to me example:

(str/foo) (set/baz) foo|

yes:

my guess: eglot is sending wrong range

When you have time, do you mind sending me lsp-mode logs please? For a sample namespace like

(ns foo)

(str/foo) bar

Or, if you know the answer w/o looking at the logs, should the client send the whole line as range?

yes, probably the issue is with the range sent on textDocument/codeAction request

Got it. By any chance, do you know if this range is Clojure-specific?

lsp-mode send this range:

{
    "start": {
      "line": 2,
      "character": 12
    },
    "end": {
      "line": 2,
      "character": 12
    }
  }

which is the cursor range

but it's not what we seek on clojure-lsp

we check the range of the diagnostics

inside context

this is the full request:

{
  "textDocument": {
    "uri": "file:///home/greg/dev/clojure-lsp/lib/src/clojure_lsp/foo.clj"
  },
  "range": {
    "start": {
      "line": 2,
      "character": 12
    },
    "end": {
      "line": 2,
      "character": 12
    }
  },
  "context": {
    "diagnostics": [
      {
        "range": {
          "start": {
            "line": 2,
            "character": 1
          },
          "end": {
            "line": 2,
            "character": 8
          }
        },
        "severity": 2,
        "code": "unresolved-namespace",
        "source": "clj-kondo",
        "message": "Unresolved namespace str. Are you missing a require?",
        "tags": []
      },
      {
        "range": {
          "start": {
            "line": 2,
            "character": 10
          },
          "end": {
            "line": 2,
            "character": 13
          }
        },
        "severity": 1,
        "code": "unresolved-symbol",
        "source": "clj-kondo",
        "message": "Unresolved symbol: bar",
        "tags": []
      }
    ]
  }
}

Thanks, this should be enough info for debugging it in eglot

I just checked that the range sent by eglot is correct:

:range
	   (:start
	    (:line 2 :character 13)
	    :end
	    (:line 2 :character 13))

(ns foo)

(str/foo) bar

On the other hand, if the point is over the highlighted error, it works:

(:jsonrpc "2.0" :id 2189 :method "textDocument/codeAction" :params
	  (:textDocument
	   (:uri "file:///Users/<redacted>/foo.clj")
	   :range
	   (:start
	    (:line 2 :character 7)
	    :end
	    (:line 2 :character 7))
	   :context
	   (:diagnostics
	    [(:range
	      (:start
	       (:line 2 :character 1)
	       :end
	       (:line 2 :character 8))
	      :severity 2 :code "unresolved-namespace" :source "clj-kondo" :message "Unresolved namespace str. Are you missing a require?" :tags
	      [])])))

Can you send me the client + server logs please?

Oh, I think I found the difference between eglot and lsp-mode requests (just installed it). In the textDocument/codeAction request, the range is indeed identical, but lsp-mode has an additional context key with the following contents:

"context": {
    "diagnostics": [
      {
        "range": {
          "start": {
            "line": 2,
            "character": 1
          },
          "end": {
            "line": 2,
            "character": 8
          }
        },
        "severity": 2,
        "code": "unresolved-namespace",
        "source": "clj-kondo",
        "message": "Unresolved namespace str. Are you missing a require?",
        "tags": []
      }
    ]
  }  

Yes, that's the issue, clojure-lsp rely on that

Eglot is not sending that probably

Yeah, it’s not sending it. I confirmed it with the logs. Thanks for the help, I just started a discussion in eglot repo

Fixed by https://github.com/joaotavora/eglot/commit/03fc783c4b701fc8c19096b7167b73bd5d8f63a8 It’s not considering the whole line, but the thing at point. I think it makes sense as well.