lsp 2022-02-14 | Slack Archive

ericdallo12:02:38

Hi everyone, I created #clojure-lsp-builds which post nightly builds of clojure-lsp! Each new commit on master now build the native binaries and post a link there! this should be useful when we want to test a fix of some issue or for people like me that use nightly builds of they favorite tools 😄! The nightly builds contains latest changes that will be available on next release, if any issue or bug, please let me know

😍 5

mpenet12:02:35

awesome, you rock

Lukas Domagala14:02:56

Since the name is always the same, do you know if there’s an easy way to just always use that with Calva?

ericdallo14:02:06

Yeah, my idea was not to use the same name, but the one used by the action but it didn't work. It's possible, on calva could be a flag to use a dev clojure-lsp which would download from that link

Lukas Domagala14:02:27

I actually kind of like that it’s always the same, that way it’s easier to grab. Although it does make the channel less useful 🙂

ericdallo14:02:06

yes, it's useful just to know if there is a new commit, but I indent to fix that somehow later

borkdude15:02:01

FWIW, in #babashka-circleci-builds I also log the commit and branch name.

ericdallo15:02:43

good suggestion @U04V15CAJ, I'll add the commit

borkdude15:02:58

branch might also be good, for testing work in progress

ericdallo15:02:11

I think build all natives for all branchs is a little too much for GH actions

borkdude15:02:35

borkdude15:02:39

makes sense!

Lukas Domagala15:02:22

Not to derail this thread, but is there a reason to use GH actions over circle ci in an open-source project? (Other then familiarity of course) Just curious, because most Clojure projects are on circle-ci.

borkdude15:02:15

I prefer CircleCI myself, even though their config is more verbose. I experience it as a more stable and performant platform (and they've given me more memory + CPU for the babashka org, else I would have switched since 4gb isn't enough).

borkdude15:02:59

Github actions is sufficient for normal JVM, Node.js etc stuff though

ericdallo15:02:12

Yes, I agree, I usually prefer GH for UX/easy configs, but circle ci has better performance indeed

Lukas Domagala15:02:54

Thanks for the explanation! 🙂

pez15:02:08

If I define cljfmt indents like so in lsp config:

:indents {foo [[:inner 0]]}

It gets represented in server-info as:

"indents": {
        "foo": [
          [
            {},
            0
          ]
        ]
      }

Why isn't it

"indents": {
        "foo": [
          [
            "inner",
            0
          ]
        ]
      }

ericdallo15:02:02

Probably a parser issue

pez15:02:52

Calva's parser?

ericdallo15:02:02

LSP One

ericdallo15:02:07

I can try soon

🙏 1

ericdallo16:02:57

I't correctly to me on serverInfo, or are you using serverInfo/raw?

ericdallo16:02:52

serverInfo/raw looks wrong indeed, we need to fix it, please open a issue

pez16:02:14

Yes, using serverinfo/raw. What's the difference here, maybe we should be using the other one?

pez16:02:16

I can only see a serverInfo/log. But that doesn't give me back the contents, instead pops up a message box.

ericdallo16:02:27

yes, for calva code, serverInfo/raw is the correct indeed

pez16:02:32

In final-settings I get the indents definition for "foo" twice, btw.:

"cljfmt": {
      "indents": {
        "foo": [
          [
            {},
            0
          ],
          [
            {},
            0
          ]
        ]
      },

pez16:02:51

And not sure if I should be using final or project. Which one does clojure-lsp use?

ericdallo16:02:08

Final

🙏 1

pez16:02:00

But the duplication there is strange...

ericdallo16:02:19

Yes

pez16:02:04

I added it to the issue.

pez16:02:15