Fork me on GitHub
#lsp
<
2021-12-20
>
ericdallo12:12:52

clojure-lsp Released clojure-lsp https://github.com/clojure-lsp/clojure-lsp/releases/tag/2021.12.20-00.36.56 with new features, fixes and performance improvements! • General ◦ Bump clj-kondo to `2021.12.19`, supporting auto-load configs, improving potemkin support, adding more linters and more, check the major release https://clojurians.slack.com/archives/C015AL9QYH1/p1639690696080500 clj-kondo ◦ Merge `:cljfmt` settings with `:cljfmt-config-path` if file path exists. ◦ Avoid high CPU and lockup when clj-kondo throws exceptions. https://github.com/clojure-lsp/clojure-lsp/pull/671 ◦ Allow absolute paths in deps.edn :local/root https://github.com/clojure-lsp/clojure-lsp/pull/672 ◦ Fix clojure-lsp not loading for some mono-repo cases, improving local/root support for polylith projects. https://github.com/clojure-lsp/clojure-lsp/pull/673 ◦ Avoid infinite loop because of cyclic dependencies on deps source-path discovery. ◦ Add babashka pod. babashka 🚀  https://github.com/clojure-lsp/clojure-lsp/issues/555 • Editor ◦ Change call hierarchy to return selection range of usage, not function definition. ◦ Return `edits` in `codeAction/resolve` responses rather than `commands`. https://github.com/clojure-lsp/clojure-lsp/issues/655 ◦ Improve `:linters :clj-kondo :async-custom-lint?` to avoid infinite loops and default to `true`. ◦ Add new custom LSP feature Test Tree, which shows all test hierarchy of a file. https://github.com/clojure-lsp/clojure-lsp/issues/653 ◦ Improve function name finding to consider other function definition types for some features. https://github.com/clojure-lsp/clojure-lsp/issues/666 ◦ Make `textDocument/hover` return the correct range from LSP spec, the element range instead of the element scope range. • API/CLI ◦ Exit process if any error during classpath lookup. Opt-out via `:api :exit-on-errors?` flag. The main focus of this release was fixing some bugs and improving lint performance, besides that we had a great feature addition with a new custom LSP feature, the Test Tree, which ATM show details about the test hierarchy of the current file, check the screenshot! We also added support for babashka pods! babashka soon, this should be available on babashka pod registry and then you will be able to run clojure-lsp directly from babashka scripts/tasks! This release was supported by Clojurists Together 💜 clojurists-together

🎉 7
Drew Verlee01:12:27

awesome!

🎉 1
djm07:12:16

Are you going to update nixpkgs with this one? I can send a PR if it helps, but in the past I think you preferred to do it yourself.

ericdallo12:12:39

@U015KH5ENEM feel free to open it! I tried create a CI that automatically opens the PR there, but it doesn't work for some reason :/ https://github.com/clojure-lsp/clojure-lsp/runs/4582175458?check_suite_focus=true

ericdallo12:12:03

I'm kind busy until weekend, so feel free to open it

djm15:12:11

:thumbsup:

djm18:12:53

I got test failures running nix-build, so I'll leave it to you 😀

ericdallo18:12:07

oh no 😅 I can take a look soon

ericdallo18:12:33

BTW @U015KH5ENEM, we have this PR but it's kind of stale, it'd be really good for nix users: https://github.com/clojure-lsp/clojure-lsp/pull/604

👍 1
dharrigan19:12:07

I'm having a bit of an issue trying to track down if this is a clojure-lsp issue. When I issue the command coc-definition, the following is sent to clojure-lsp:

dharrigan19:12:24

[Trace - 19:01:14] Sending request 'clojure/dependencyContents - (12)'.
Params: {
    "uri": "/home/david/development/clojure/websockets/jar:file:///home/david/.m2/repository/juxt/clip/0.27.0/clip-0.27.0.jar!/juxt/clip/core.cljc"
}


[Trace - 19:01:14] Received response 'clojure/dependencyContents - (12)' in 1ms.
No result returned.

ericdallo19:12:58

Weird, never saw that

dharrigan19:12:38

Yeah, it's only relatively recently started to happen

ericdallo19:12:08

could you try a previous clojure-lsp version?

dharrigan19:12:09

(I doubt it's coc, since the last update to that was in July)

dharrigan19:12:25

happens in previous one too (I'm bang up to date, and I've been noticing it for a while)

dharrigan19:12:33

Let me go back 1 month 😄

dharrigan19:12:28

I do see this in the output java.net.MalformedURLException: no protocol: /home/david/development/clojure/websockets/jar:file:///home/david/.m2/repositor>

dharrigan19:12:40

(it's truncated a bit, terminal...)

dharrigan19:12:16

happens on latest

dharrigan19:12:59

Thinking...I do think the /home/david.... up to jar is wrong

ericdallo19:12:09

does it happens only on latest?

dharrigan19:12:08

Naw, happens even going back to July, so it's got to be a change to how neovim works (they broke things with zipfile:/// that both conjure and vim-fireplace had to work around)

dharrigan19:12:18

So, I'll do some more digging

ericdallo19:12:40

yes, makes sense

ericdallo19:12:51

no emacs/calva user reported anything, so that would make sense

dharrigan12:12:41

Figured it out (with some help from the #vim channel on irc)

dharrigan12:12:08

Seems that using <amatch> in an autocommand to open up the contents is no longer working (for me), so using <afile> fixed it.

👍 1
dharrigan19:12:49

Is it right that no result is returned? (I can confirm the jar exists in my path)