using the latest version of clojure-lsp

weirdly I can't even replicate it running the same command inside the same docker container

but it only happens when running in CI

That's weird, have no idea what error is that

Is there any log or something where I can see ?

mm no sadly

but strangely it also stopped happening now

yeah probably be ignored, some weird thing happened on the machine that was running it maybe

mm

If your project is a deps.edn, clojure-lsp will scan the deps.edn file for :paths, :extra-paths and the paths from the specified :source-aliases setting (default #{:dev :test}), unless you specified :source-paths manually.

but it's not really working though

because there is paths and a few extra-paths

should they be merged together?

yes, could you check clojure-lsp log? we log which source-paths we resolved

it's the first log when server starts

How to get the log: http://clojure-lsp.github.io/clojure-lsp

mm yeah weird src/cljs is not picked up

even though it's in extra-paths

there are multiple extra-paths

from what I see it might be just taking the last extra-paths it finds

instead of merging them together

hum, maybe

could you open an issue with a minimal deps.edn that repro the issue?

let me see if I can replicate it with a trivial example

https://github.com/clojure-lsp/clojure-lsp/issues/616

thanks! I can take a look later today

great thanks

Hello! I think lsp-ui-doc-show should be what you are looking for

the glance one is just for some quick view I think

Personally, I don't use lsp-ui-doc, I use eldoc emacs integration via doom-emacs which shows the doc in a separate buffer

I see, thank you.

Oh never saw that :thinking_face:

@UE21H2HHD how those actions on rewrite-clj works?

It tries to compile clojure-lsp with your rewrite-clj changes?

Yeah, patches clojure-lsp deps with locally installed rewrite-clj jar built off rewrite-clj master.

Oh, that's cool

I'll try to take a look in about 1hour

To check If I know anything

But nothing come to my mind right now

But I'm not suspecting rewrite-clj - not much has changed in a long while. More guessing we just hit a JDK bug.

Your clojure-lsp program is so sophisticated even modern JVMs can't handle it!

Hahaha wish it was that

Just relaunched failed gha job and clojure-lsp worked fine (it is a sporadic failure).

Yeah, really sounds like a jdk corner case issue, maybe try other jdk versions? Clojure-lsp CI test java 8, 11 and 15

Maybe it could be the jdk you are using, maybe try use the same I use on clojure-lsp GH action?

I switched from openjdk to temurin recently. Using temurin JDK 11 for all canary lib testing.

(well I guess that was not a switch but responding to a rename)

Looking at your workflow, clojure-lsp is still using setup-java@v1... so that means it is using Zulu I think.

Hum, probably, I missed that

I'm guessing there is nothing for us to solve here. Really more just wanted to make you aware.

Probably needs to bump/test a recent version

Yeah, I'll test other jdks later, thanks for letting me know!

Meh, Zulu might be fine. It was only setup-java@v2 that started letting you specify the distribution if I remember correctly.

Or who knows, might have something to do with lmdbjava-native-library which I see in the fatal error report.

Uh, this comes from datalevin for sure, maybe @U0A74MRCJ knows something about it

And we migrated to use datalevin instead of sqlite in the last release

Ah, that might be the interesting thing! I guess you could try running your test suite in a loop and see if it eventually fails.

yeah, with the same openjdk you use on CI you mean, right?

Interesting, this is from a compiled lmdb dynamic library, done by lmdbjava, they uses an older version of lmdb, so maybe i should compile my own

probably that should help with graalvm image compiled with musl/static 👀

it would to nice to have a reproducible case

this error is from the jvm version

so I don’t know

lmdbjava-native-library-xxx is from LMDBJava, which is not used in our GraalVM version, we compile our own LMDB (same version of LMDB as JVM one though) in GraalVM version

it would be helpful to have a test case that reproduce this error.

LMDB is compiled as static library in our graalvm version, but it is against glibc, so something might be different from musl

btw, does musl works on all OS? windows, and macos?

I htink only linux @U0A74MRCJ, not sure though

ok, then the build script will need to do something different depending on OS, i can give it a try when I get the things off my plate.

no problem, thank you!

I'm a Nix user so the only binary that should work correctly on my machine is a musl static one :)

oh i see

i would like this to be out in the next major release, because this may introduce breaking changes

i don’t want to break people’s database with a minor version bump

the next release is full-text search feature, i have done bulk of the work, needs to optimize here and there

maybe no breaking change is necessary, we will have to see

I see, take your time :)

FWIW, I looked up a previous failure on GitHub Actions from a few days ago, looks very similar to the one I reported today: https://github.com/clj-commons/rewrite-clj/runs/3970926620?check_suite_focus=true#step:9:3098 I'm not sure how long these logs are preserved, so you might want to grab copies.

i think i may have some ideas on the fix, will see if it works

@U0A74MRCJ just curious, did you manage to trigger a reproducible failure?

it can happen when multiple threads trying to write at the same time

or program shutdowns abruptly

0.5.27 is released to hopefully address this problem

Thanks! I should bump clojure-lsp soon, but I think only next clojure-lsp release will affect @UE21H2HHD

Nice sleuthing @U0A74MRCJ!

@ericdallo if I bumped into this on CI I expect others will have bumped into it too! After the upgrade, I’ll be sure to let you know if CI fails for me again.

@ericdallo I’ve bumped to the current clojure-lsp for my rewrite-clj canary tests. I’ll letcha know if I see any more JVM crashes on CI.

Thank you!

No problem haha