yes, I already noticed that, it would be a good feature indeed

90% of the time clojure-lsp sorts according to how we like it, but not all of the time. Especially relating to long lists of imported classes or long lists of refers. If this is enabled, please have a way to disable it

yes, have it opt-in perhaps, rather than opt-out 😉

@U11BV7MTK Can you elaborate an example on how the sort doesn't makes sense?

Shall I raise an issue on the venerable github?

yeah. i don't care which way the default is. as long as it is configurable

yeah the easiest way for me to check this would be to run the command line option to sort the ns's. do you know that offhand?

i'll look at the diff

oh nice. there's a --dry option. Although it seems that the command line doesn't use the existing cache? i'm at 54,000 ms analyzing the project

final runtime to analyze: Analyzing project... 144150ms

it should use the cache @U11BV7MTK

[email protected] metabase % clojure-lsp --dry clean-ns
Analyzing project... 144150ms
Checking namespaces...
[email protected] metabase % clojure-lsp clean-ns --dry
Analyzing project... 151930ms
Checking namespaces...

but no diff came from it, nor any files changed. now just running without --dry and i'll just discard any diffs it changes

seems it's happening an error, could you try with --verbose?

as soon as this run ends i'll do that

ok it ran fine without --dry

-            [metabase.models :refer [Card Collection Dashboard DashboardCard Database Field Metric NativeQuerySnippet
-                                     Pulse Segment Table User]]
+            [metabase.models :refer [Card Collection Dashboard DashboardCard Database Field Metric NativeQuerySnippet Pulse Segment Table User]]

here it removed newlines in long lists of refers

I see, so would be ideal to clojure-lsp keep the newlines on refers, right?

probably a opt-in flag to keep new-lines makes sense I think

or just always keep :thinking_face:

yeah. also removed a comment

-            [metabase.query-processor-test.order-by-test :as qp-test.order-by-test] ; used for one SSL connectivity test
+            [metabase.query-processor-test.order-by-test :as qp-test.order-by-test]

yeah, we can probably improve that logic

java.util.concurrent.TimeUnit
+           org.apache.sshd.client.SshClient
            org.apache.sshd.client.future.ConnectFuture
            org.apache.sshd.client.session.ClientSession
            org.apache.sshd.client.session.forward.PortForwardingTracker
-           org.apache.sshd.client.SshClient

here it sorted refers capital S before lowercase d

[medley.core :as m]
-            [metabase.models.setting :as setting :refer [defsetting Setting]]
+            [metabase.models.setting :as setting :refer [Setting defsetting]]

(as an addition, I noticed too, that if I have something like #_{:clj-kondo/ignore.....} against a require/import and I sort it, that gets removed too)

It seems valid, Please open an issue with those details @U11BV7MTK so I can investigate later

will do. do you want a single issue with these or each one as a separate issue?

I think one for the comments and another for the sorting

Thank you for the detailed issues @U11BV7MTK I'll try to take a look soon!

thank you for this amazing work

Yes! It was changed on latest release: https://clojurians.slack.com/archives/CPABC1H61/p1631563489180000

this was something bad for gitignores but the ideia is to move the db impl to a .cache folder

and when we change the db impl in the future, this will cause no more issues for users

OK, I'll update the various gitignore templates in clj-new and deps-new then.

clojure-lsp has already a logic to auto move the .lsp/sqlite.db to .lsp/.cache/sqlite.db

thank you @U04V70XH6!

@U04V70XH6 if you update those templates, do you also include .clj-kondo/.cache ?

@U04V15CAJ https://github.com/seancorfield/clj-new/blob/develop/src/clj/new/lib/gitignore

Thank you!

Thank you :) What editor are you using?

doom emacs

Alright, this tutorial should certainly help you: https://emacs-lsp.github.io/lsp-mode/tutorials/clojure-guide/

but since you use doom you can find probably most of commands with SPC c witch will prompt all the commands for the code section

Perfect! I thought I had seen this but couldn't find it again

Ah, I'm not in evil

for example, for find references/usages of a function you can use SPC c D

Do you by chance know the non evil mode hot keys?

AFAIK the evil keybindings are g D for example, the one I told was the doom-emacs one that is available for both users :thinking_face:

anyway, you can probably check that with: M-x and then type lsp- , this will show all available commands and the keybindings if any for those commands :)

also, make sure you enabled +lsp module in your init.el

this is my doom config: https://github.com/ericdallo/dotfiles/tree/master/.doom.d

Ok, didn't connect a couple dots. Now I see them

Their are just a ton of commands so I didn't see key bindings next to them. Now when I scroll down I do

sweet, just what I needed! Thanks again

cool :) Good coding!

Ok, I'm rolling now and my mind is blown. Execute code action was what I was really missing.

I start with clj-kondo and had to specify a couple of my helix helpers should be used like defn, do I move that to .lsp?

yeah, usually is SPC c a on doom-emacs

I have a defcompoent macro that I would love to see the usages next to the symbol

nope, clojure-lsp use clj-kondo under the hood

so your clj-kondo config should work with clojure-lsp as well

you just need to have properly configured on .clj-kondo/config.edn

there is this code action as well: https://clojure-lsp.io/features/#resolve-macro-as

With clj-kondo I have

:lint-as {mxv.client.react/defrc   clojure.core/defn
           helix.hooks/use-callback clj-kondo.lint-as/def-catch-all
           helix.hooks/use-memo     clj-kondo.lint-as/def-catch-all}

And that lints as expected. Do I need something different for the usages to work?

ah, checking your link above now

that code action will just add the configuration to the lint-as as you pasted above

that should work

some things to confirm: • make sure you have latest clojure-lsp • remove .lsp/.cache and restart the server with lsp-workspace-restart if you changed the clj-kondo config after started

k, checking on those

it's possible to configure the clj-kondo config on the lib itself, making it easy for users of that lib

Check https://github.com/clj-kondo/clj-kondo/blob/master/doc/config.md#exporting-and-importing-configuration

this is an example: https://github.com/nubank/state-flow/tree/master/resources/clj-kondo.exports/nubank/state-flow

so users just need to add to their clj-kondo config something like :

{:config-paths ["nubank/state-flow"]}

Amazing, just what I was hoping for. Thanks again

Perhaps we can collect libraries with such config in the clj-kondo readme

so we have lot of examples

that would be really nice!

Yeah that would be great

OR a badge/link or something even on readme signifying it's clj-kondo compliant and available to import the config

Maybe overkill

:)

https://github.com/clj-kondo/clj-kondo/issues/1383

I added helix to that, I'm gonna try and remove my custom config for that and import to make sure I'm getting the setup

I just noticed that lsp automatically dumped the rewrite-clj config in my .clj-kondo dir :) Since I'm not using that in nbb, I simply added it to the .gitignore

Added a bunch more

awesome! I have on my backlog, down there, to open an PR on https://github.com/plumatic/plumbing 😅 for fnk macro and probably others

you mean https://clojure-lsp.io/features/#code-lenses-showing-symbol-references?

Yes exactly

Do I call that manually when I want to see the results then?

for emacs, you need to (setq lsp-lens-enable t)

ah, ok. THanks

and lsp-mode will always activate them when kicks in