Fork me on GitHub
#lein-figwheel
<
2018-02-21
>
bhauman15:02:19

would appreciate if folks could give [lein-figwheel "0.5.15-SNAPSHOT"] a try (edited) running lein figwheel should give you a terminal rebel readline config :figwheel -> :readline false should disable it if you aren't using leinigen then adding a rebel-readline:0.1.1-SNAPSHOT to your deps along with figwheel-sidecar:0.5.15-SNAPSHOT should also get you a rebel readline repl I really need to know if this is working for folks so I can make a real release

bhauman16:02:39

terminals are notorious so its tough to move ahead without a decent number of folks reporting success if you find something please report it, and include terminal/platform info Thanks!!

shaun-mahood17:02:10

I updated my current project (using Cursive REPL and chestnut template) and there are no obvious issues running it that way, rebel readline shows up when I run with lein figwheel as well (Ubuntu). Off to try it on Windows and Mac!

shaun-mahood17:02:38

All good on my Mac as well for both tests.

shaun-mahood17:02:54

Unsurprisingly it doesn't work in the regular Windows command line - I would be a little shocked if it did. Error message is

Feb 21, 2018 10:21:54 AM org.jline.utils.Log logr
WARNING: Unable to create a system terminal, creating a dumb terminal (enable debug logging for more information)
If nobody else beats me to it I'll try it with the Windows Subsytem for Linux, but I haven't got it running on any of my machines so I'll have to get up the energy to mess with things first.

bhauman17:02:58

@shaun-mahood on Windows did the REPL still start without readline support and how did you launch it?

shaun-mahood17:02:52

REPL fails to start on Windows, so I guess that is a problem 🙂

bhauman17:02:29

and you are launching with lein figwheel?

shaun-mahood17:02:44

Launched with lein figwheel from the windows command line on a project from lein new figwheel where all I changed was updating the figwheel deps

bhauman17:02:45

yeah you said so above

bhauman17:02:30

could you do me one favor on Windows? and see if clojure -Sdeps "{:deps {rebel-readline {:mvn/version \"0.1.1-SNAPSHOT\"}}}" -m rebel-readline.main works?

bhauman17:02:02

bc I think it's a trampoline problem on Windows possibly

shaun-mahood17:02:50

I don't think there's a way to install the clojure command on Windows yet, at least according to https://clojure.org/guides/getting_started (though I think it's in the works somewhere)

bhauman17:02:05

oh that makes sense

bhauman17:02:49

how about lein trampoline run -m rebel-readline.main?

shaun-mahood17:02:05

I reverted figwheel to 0.5.14 and confirmed that figwheel will run again, added [rebel-readline "0.1.1-SNAPSHOT"] to my dependencies and ran lein trampoline run -m rebel-readline.main, here's the start of the error message I get back

Feb 21, 2018 10:54:20 AM org.jline.utils.Log logr
WARNING: Unable to create a system terminal, creating a dumb terminal (enable debug logging for more information)
Exception in thread "main" clojure.lang.ExceptionInfo: Unable to create a system Terminal, you must
not launch the Rebel readline from an intermediate process i.e if you
are using `lein` you need to use `lein trampoline`. {:type :rebel-readline.jline-api/bad-terminal}, 

bhauman17:02:48

@shaun-mahood Thanks! thats very helpful.

shaun-mahood17:02:01

Separately, it runs fine on my Ubuntu box under fish, zsh and hyper

bhauman17:02:18

I'm sure there is a terminal emulator that runs on windows

shaun-mahood17:02:42

Yeah, I assume it will work fine under both Cygwin and the new Windows Subsystem for Linux. Always nice to know how things fail under regular Windows command lines though (since they almost always need specific tweaks to handle something different).

bhauman18:02:16

but things like comemu should work

shaun-mahood18:02:10

If I get a chance I'll test that as well as cygwin and wsl

bhauman19:02:22

I just deployed changes the repl should start on windows now, but not with readline support

souenzzo19:02:10

@bhauman archlinux+lxterminal: lein new figwheel my-test+`vim project.clj`+`lein figwheel` = awesome repl. Great work! Waiting a alpha release to use in my production project.

shaun-mahood21:02:33

Changes for Windows look good, figwheel repl is working fine.