Fork me on GitHub
#lein-figwheel
<
2015-12-06
>
bhauman16:12:03

@eyelidlessness: figwheel compilation exceptions and warnings only go to the client and the figwheel_server.log

bhauman16:12:09

Not sure I understand your second comment about the only way to get output.

eyelidlessness16:12:23

Was talking about producing output in the repl from, e.g. a fs watcher. I ended up being able to do so by sending a message to the client then printing from there.

eyelidlessness16:12:46

but all may be moot with the notify-command PR, if you accept it

bhauman16:12:15

Didn't see that yet

eyelidlessness16:12:02

(apologies for the whitespace noise, my editor does that on save)

bhauman16:12:06

ClojureScript.java.shell!,

eyelidlessness16:12:51

well, clojure.java.shell

bhauman16:12:48

@eyelidlessness: I wonder if we should just have a :notify-fn much more general

eyelidlessness16:12:16

as in, call an arbitrary clj function?

eyelidlessness16:12:14

it may be confusing to have something similar to, but not the same as, cljsbuild, sitting in a cljsbuild config param

eyelidlessness16:12:40

i could see it both ways, and certainly the clj function would be more idiomatic

eyelidlessness16:12:02

i already feel strange having an arbitrary shell call in :test-commands

bhauman16:12:53

It seems that it would be more useful

bhauman16:12:07

But less convenient@for@this case

bhauman16:12:21

Hard to type on an iPad

eyelidlessness16:12:28

ultimately either one can accommodate the other

bhauman16:12:03

Doesn't really go both ways though

bhauman16:12:41

We could have both one being a specialization of the other

eyelidlessness16:12:06

imo supporting :notify-command is nice because it is what i expected when running figwheel with cljsbuild config. supporting an arbitrary on-compile fn would also be nice, but from the figwheel config so as not to confuse cljsbuild users

bhauman16:12:27

Just so you know, the intention is not to follow and support changes in cljsbuild functionality. It's just a convenient source of config information. You can place your :builds in the :figwheel config in fact I'm debating about making this the implicit default in the docs so that folks aren't confused about these things

eyelidlessness16:12:58

i guess to me, supporting it partially is confusing and unexpected.

bhauman16:12:13

Figwheel initially used cljsbuild and hooked into it

bhauman16:12:25

So it's a legacy thing

eyelidlessness16:12:34

perhaps the right course of action is to deprecate it and focus on the figwheel api in docs?

bhauman16:12:51

It's probably time to do that

bhauman16:12:03

You mean the REPL api?

eyelidlessness16:12:26

i mean the project config api. i actually wasn't even aware you could specify :builds

eyelidlessness16:12:57

granted my introduction to figwheel came through installing the reagent template

eyelidlessness16:12:18

which has its own (somewhat hodgepodge) opinions of project config

bhauman16:12:46

Well you can also have a figwheel.edn now ;)

bhauman16:12:13

Things are still unstable in terms of best practices.

eyelidlessness16:12:50

having so many ways to do things is also confusing, but that honestly is a frustration i have with project.clj in general

bhauman16:12:56

Documentation gets much easier as things stabilize

eyelidlessness16:12:08

i do prefer having my project configured in one place tho

bhauman16:12:49

BTW thanks for the PR I'm going to pull it in now :) I really appreciate it.

eyelidlessness17:12:58

it looks like you release fairly frequently too

karol20:12:41

Hi, sorry for noob question but could someone redirect me to some tutorial about deploying figwheel clojurescript project to server? I created ring handler in separate clj file in project and added key in figwheel configuration :ring-handler but what now? I also tried adding ring plugin to project.clj and then creating jar by lein ring uberjar. Server starts, sees my index.html but not compiled .js file 😕