Fork me on GitHub
#keechma
<
2018-07-21
>
Garrett Hopper16:07:09

Is there a reason for keechma-router to have public/index.html in the build? It's colliding with figwheel and causing problems.

Garrett Hopper17:07:21

@mihaelkonjevic, it looks like @bhauman went ahead and created an issue for this: https://github.com/keechma/router/issues/1

mihaelkonjevic17:07:22

@ghopper New version (0.1.2) is released which addresses this issue

Garrett Hopper17:07:11

@mihaelkonjevic, will that new version be in keechma, or should I just add a dependency for the 0.1.2 router in addition?

mihaelkonjevic17:07:18

Add explicit dependency for now. I'll make a new keechma release in a day or two (I have some other things I've planned for this release)

Garrett Hopper17:07:19

:thumbsup: Thanks for the quick turnaround. πŸ™‚ Now lein-doo has a public/index.html... πŸ˜•

Garrett Hopper17:07:47

:scope "test", I guess

mihaelkonjevic17:07:56

Yeah, it can. I think you can add it as an exclusion. BTW which lein template are you using? I don't have any of these problems in keechma template so I'd like to check what's going on (to make sure this is not happening)

Garrett Hopper17:07:42

Oh, I'm using deps.edn. I'll do an exclusion; thanks for the idea.

mihaelkonjevic17:07:41

Ah, ok I'll check how it works with deps.edn then

Garrett Hopper17:07:55

Hmm, deps.edn doesn't seem to accept my :exclusions. πŸ˜•

mihaelkonjevic18:07:21

@ghopper can you send me your deps.edn file?

Garrett Hopper18:07:22

@mihaelkonjevic I've got a lot of misc aliases and whatnot in my deps.edn. This reproduces it though:

{:deps {org.clojure/clojurescript {:mvn/version "1.10.339"}
        keechma/keechma {:mvn/version "0.3.12" :exclusions [lein-doo]}
        keechma/router {:mvn/version "0.1.2"}}}
clj -Stree shows lein-doo

mihaelkonjevic18:07:58

Try adding it as an exclusion to the router too

mihaelkonjevic18:07:40

I'm using lein-doo in all keechma related projects. I'll have to go and cleanup all of the project.clj files

Garrett Hopper18:07:20

(from clj -Stree)

keechma/keechma 0.3.12
  com.cognitect/transit-cljs 0.8.239
    com.cognitect/transit-js 0.8.846
  cljsjs/react-with-addons 15.6.1-0
  lein-doo/lein-doo 0.1.7
    doo/doo 0.1.7
      karma-reporter/karma-reporter 0.1.0
  syntest/syntest 0.1.0
    cljsjs/jquery 3.2.1-0
    funcool/promesa 1.9.0
  org.clojars.mihaelkonjevic/cljs-react-test 0.1.5
    camel-snake-kebab/camel-snake-kebab 0.4.0
  prismatic/dommy 1.1.0
  com.stuartsierra/dependency 0.2.0

Garrett Hopper18:07:30

I added it to the router as well.

mihaelkonjevic18:07:20

@ghopper Try adding it as lein-doo/lein-doo

mihaelkonjevic18:07:31

It works for me. This is the output:

mihaelkonjevic18:07:35

clj -Stree
org.clojure/clojure 1.9.0
  org.clojure/core.specs.alpha 0.1.24
  org.clojure/spec.alpha 0.1.143
keechma/router 0.1.2
  secretary/secretary 1.2.3
    com.cemerick/clojurescript.test 0.2.3-SNAPSHOT
org.clojure/clojurescript 1.10.339
  org.clojure/data.json 0.2.6
  org.clojure/google-closure-library 0.0-20170809-b9c14c6b
    org.clojure/google-closure-library-third-party 0.0-20170809-b9c14c6b
  org.mozilla/rhino 1.7R5
  com.cognitect/transit-clj 0.8.309
    com.cognitect/transit-java 0.8.332
      commons-codec/commons-codec 1.10
      com.fasterxml.jackson.core/jackson-core 2.8.7
      org.msgpack/msgpack 0.6.12
        com.googlecode.json-simple/json-simple 1.1.1
        org.javassist/javassist 3.18.1-GA
  org.clojure/tools.reader 1.3.0-alpha3
  com.google.javascript/closure-compiler-unshaded v20180610
    com.google.errorprone/error_prone_annotations 2.0.18
    com.google.jsinterop/jsinterop-annotations 1.0.0
    com.google.javascript/closure-compiler-externs v20180610
    com.google.guava/guava 22.0
      org.codehaus.mojo/animal-sniffer-annotations 1.14
      com.google.j2objc/j2objc-annotations 1.1
    args4j/args4j 2.33
    com.google.protobuf/protobuf-java 3.0.2
    com.google.code.findbugs/jsr305 3.0.1
    com.google.code.gson/gson 2.7
keechma/keechma 0.3.12
  cljsjs/react-dom 15.6.1-0
  com.cognitect/transit-cljs 0.8.239
    com.cognitect/transit-js 0.8.846
  cljsjs/react-with-addons 15.6.1-0
  reagent/reagent 0.7.0
    cljsjs/create-react-class 15.5.3-0
  cljsjs/react-dom-server 15.6.1-0
  syntest/syntest 0.1.0
    cljsjs/jquery 3.2.1-0
    funcool/promesa 1.9.0
    org.clojure/core.async 0.3.443
      org.clojure/tools.analyzer.jvm 0.7.0
        org.clojure/tools.analyzer 0.6.9
        org.clojure/core.memoize 0.5.9
          org.clojure/core.cache 0.6.5
            org.clojure/data.priority-map 0.0.7
        org.ow2.asm/asm-all 4.2
  org.clojars.mihaelkonjevic/cljs-react-test 0.1.5
    camel-snake-kebab/camel-snake-kebab 0.4.0
  prismatic/dommy 1.1.0
  com.stuartsierra/dependency 0.2.0

Garrett Hopper18:07:06

I tried that, but it wasn't on both. I'll try that.

Garrett Hopper18:07:28

@mihaelkonjevic, it works, but I still get the the index.html from . πŸ˜•

Clojure 1.9.0
user=> (require ')
nil
user=> ( "public/index.html")
#object[java.net.URL 0x6b4a2887 "jar:file:/data/prs/m2/repository/keechma/keechma/0.3.12/keechma-0.3.12.jar!/public/index.html"]
user=>

mihaelkonjevic19:07:34

@ghopper I’ve pushed keechma 0.3.13 . It includes the latest router and it doesn’t have the resources folder in the keechma project

Garrett Hopper19:07:40

Heh, now I've got a syntest public/index.html. πŸ˜›

mihaelkonjevic19:07:09

You can also exclude syntest, it's for test purposes. What is the command you're using for running the app? I'll try to clean everything up tomorrow

Garrett Hopper19:07:29

Yeah, I'll need to see if that's the last step needed later. I've got a flight to catch.

Garrett Hopper19:07:45

Thanks for taking care of this so quick.

mihaelkonjevic19:07:48

No problem, feel free to ping me if you have any questions

Garrett Hopper19:07:08

@mihaelkonjevic keechma/keechma {:mvn/version "0.3.13" :exclusions [lein-doo/lein-doo syntest/syntest]} works like a charm. πŸ™‚ Thanks!

πŸŽ‰ 4