Fork me on GitHub
#kaocha
<
2020-11-26
>
Alys Brooks03:11:26

While the test.check issue isn't fully addressed yet, we do have other improvements, including an established order of configuration for kaocha.plugin.alpha.spec-test-check and validation of configuration options. The validation does mean that some existing configurations may fail, although most should be able to be fixed so they work. Please let us know if you have an issue updating yours. See the CHANGELOG for more details: https://github.com/lambdaisland/kaocha/blob/main/CHANGELOG.md#10726-2020-11-24--faa6ef6

👍 3
👏 3
plexus08:11:24

I put out lambdaisland/kaocha "1.0.732" based on @actuallyalys_slack’s fix. Please let us know if you run into any more issues!

👍 3
salam20:11:10

just verified the quick fix. thanks!

plexus07:11:11

it shouldn't have been an issue for so long... glad that it's fixed now.

plexus08:11:15

Also welcome to the team Alys! https://gaiwan.co/about/

reefersleep18:11:37

Only a couple of months after, I’m creating the plugin I said I’d do. 🙂 Don’t know if you remember, @plexus, but you helped me out with a git hook for Kaocha. I’m piecing it together as a plugin now.

reefersleep18:11:39

One thing I’m wondering; when I was developing the :post-summary hook, I couldn’t check it in the repl using run. I still can’t. Should I raise this as an issue at the repo, or is it a non-starter?

reefersleep18:11:54

It sure would be nice for iteratively developing post-summary plugins 🙂

plexus07:11:07

Are you on the latest version? looking at the changelog kaocha.repl should call post-summary starting from 1.0.658

reefersleep22:11:00

Need to check again, but I used the latest version mentioned in the repo when I worked on it yesterday.

reefersleep18:11:36

But I can’t remember if there’s a good reason that the post-summary isn’t hit when you call run.

reefersleep18:11:33

The documentation is helping me along nicely; I’ve already got it up and running!

reefersleep18:11:12

Btw, in a very roundabout way, I found what I assume to be a spelling error in one of the specs: https://github.com/lambdaisland/kaocha/blob/613925892420a99bfe35a492a84ea34b2be98efb/src/kaocha/specs.clj#L90 ( :kaacha )

reefersleep22:11:34

Made a PR for that 🙂

plexus07:11:26

Thanks! merged!

🍻 3