Fork me on GitHub
#juxt
<
2019-01-22
>
andrea.crotti09:01:15

is this a good place to ask a question about Aero?

urbanslug11:01:29

Crossposting because I didn't find a response about edge in #yada so I I thought I'd ask here: I've watched the edge demo and read the docs and I'm looking at the code. I feel that edge is aimed towards a single repo for all your services. This is because none of these libs are published and the references to edge libs are all relative. e.g. ../lib.app.dev Am I missing something?

andrea.crotti12:01:56

@malcolmsparks I saw you merged already: https://github.com/juxt/aero/pull/69 it was still WIP because I didn't get it work yet

andrea.crotti12:01:09

but well I didn't break it I guess since it was already not working anyway

andrea.crotti12:01:52

I'll do another PR when I get it work, in theory you might also want to set in the github settings for the repo to check for the two test-clj and test-cljs jobs, because atm they are not really enforced to pass (once the tests are all passing at least)

andrea.crotti12:01:22

I would have also squashed my commits if I knew it was going to be merged, I'll just mark it as WIP more clearly next time sorry about that

malcolmsparks12:01:32

ok - thanks for the info, I'll back out the PR

andrea.crotti12:01:37

ok @malcolmsparks https://github.com/juxt/aero/pull/70 now everything works

andrea.crotti12:01:47

and it's a more proper PR with just one commit

dominicm12:01:17

Looks good

andrea.crotti13:01:43

only think I haven't done is to add some caching

andrea.crotti13:01:55

but it's so fast anyway so it doesn't matter so much

dominicm13:01:08

I think this is great