Clojurians
#java
<
2018-06-29
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dpsutton03:06:03

any java people available to help me get https://gitlab.ow2.org/asm/asm up and running so i can run some tests and make a patch? it's gradle based and I have no idea where to start :slightly_smiling_face:

seancorfield03:06:49

@dpsutton Is this to address the bug I reported?

dpsutton03:06:30

but i figured out gradlew so I can run tests now

dpsutton03:06:42

I have 4 years in C# and none in java proper

dpsutton03:06:20

you said we call byte to short as well, right?

dpsutton03:06:29

in addition to the byte -> int

seancorfield03:06:04

short to int fails

dpsutton03:06:05

ah. is that a no-op? i have no idea about these types in java :slightly_smiling_face:

seancorfield03:06:16

Yeah, promotion is "free". The .cast() call deals with all the non-int from cases first and then all the to cases -- and throws an exception on no-ops now (where from != to).

seancorfield03:06:30

(from memory -- I'm watching TV and not looking at the source)

dpsutton03:06:29

yeah. I think maybe just getting rid of the exception is the way to go?

seancorfield03:06:46

FWIW, when I tested Clojure and my patch, I ran all the tests first (there was a failure, unrelated), then I added my fix and made sure it didn't break anything, then I added my tests and made sure those past, then I removed my fix and made sure the extra tests failed, then put my fix back (and re-tested).

seancorfield03:06:36

casts from long/double/float (and maybe others) to int all work -- those are handled just fine by the ASM code.

seancorfield03:06:57

It's only short->int and byte->int as far as I can tell.

seancorfield04:06:17

Good stuff @dpsutton!

seancorfield04:06:28

Alex indicated there would be no fix applied to Clojure for a few weeks due to other commitments so I may well build a variant of Alpha 5 with my fix and run a bunch of tests against the World Singles code base...

dpsutton04:06:46

they should just revert the asm update until its resolved i guess

dpsutton04:06:17

but i have no idea what the implications of that dependency is, how old, etc

dpsutton04:06:42

and wow. i forgot what its like to code in C#/java. I don't miss it lol

seancorfield05:06:26

Reverting the ASM update doesn't seem like a solution to me.

seancorfield05:06:55

Either apply my patch, or update the local re-vendored copy of GeneratorAdapter.