Fork me on GitHub
#jackdaw
<
2019-07-25
>
xi06:07:31

I mean that the key serde I pass through still doesn't seem to take effect 😞

xi06:07:06

I would normally write a test but I was a little put off by not being able to see any others around custom serdes

xi07:07:35

Having a go now, laziness overcome by expediency

xi09:07:51

My autoformatter fixed some minor issues in the test file, I can remove those if it's an issue

cddr10:07:21

Yeah if you don't mind that would be appreciated.

xi10:07:54

Can I supply a second PR to fix them?

cddr10:07:41

Yep

👍 4
xi09:07:27

I actually don't understand the result for L954, but the serdes work so ^^

xi10:07:39

Got my local bug 🙂 it had the same failure condition as the Jackdaw bug I fixed, which is why I thought the PR was broken initially

cddr10:07:56

Cool. I thought the PR looked good. Great to hear it's working for you now. I'll get a few more 👀 on it today.