Fork me on GitHub
#inf-clojure
<
2022-05-28
>
wanz04:05:33

hey @dpsutton any progress on this issue? https://github.com/nrepl/nrepl/issues/272 I'm also using nrepl + tty & inf-clojure

dpsutton23:05:39

@jasonkdarby i left a comment on the switch-to-repl PR about the way CIDER uses (buffer-list) rather than trying to keep a variable up to date

Jason00:05:17

I do really like the idea of not keeping the extra variable around but I don't understand the workflow. I don't personally use it, I just cycle through other-window (with M-o, I'm not entirely insane), so I've never used the similar functionality in CIDER

dpsutton00:05:11

the workflow is basically the same as you wanted to provide in your PR?

dpsutton00:05:10

ie, C-c C-z takes you to the repl buffer when you're in a clojure mode buffer. If you are in a repl buffer, C-c C-z takes you to the last inf-clojure-minor-mode buffer (aka clojure source code buffer)

dpsutton00:05:32

which is what your PR does except it uses a variable to keep track of it and requires you to use the shortcut instead of "just working"ā„¢

Jason00:05:41

Ok, yeah I understood it as "`C-c C-z` takes you to the repl buffer when you're in a clojure mode buffer. If you are in a repl buffer, C-c C-z takes you to the last inf-clojure-minor-mode buffer you invoked C-c C-z from."

Jason00:05:50

I'll give it a shot with your suggestion

dpsutton00:05:27

right. so just drop the requirement "you invoked C-c C-z from" since that could lead to bewildering results and requires you to remember how you got to the repl

dpsutton00:05:48

just grab the first buffer from (buffer-list) that has inf-clojure-minor-mode active and that's the target buffer

šŸ‘ 1
Jason00:05:37

lol can you imagine what it's like to work with me

dpsutton00:05:05

i'm sure you're great. you are improving tooling šŸ™‚ sounds like a great coworker

awesome 1
Jason03:05:50

FYI I think I fixed it. To anybody interested, this fix is part of JasonKDarby/inf-clojure:master, along with my other PR.

dpsutton22:05:03

@jasonkdarby i'll use these two changesets on tuesday and get them merged if all good

gratitude-thank-you 2
Jason17:06:01

@dpsutton did you get a chance to use them?

dpsutton15:06:54

iā€™m applying the patches now. sorry about that