Fork me on GitHub
#inf-clojure
<
2021-02-13
>
bozhidar16:02:49

@audiolabs If I recall correctly otherwise you'd get several ghost prompts from comint-mode.

bozhidar16:02:14

(each newline would result in some blank prompt being displayed)

Robert Randolph16:02:28

@bozhidar if I remove that code (`inf-clojure--make-single-line`), I do not get that behaviour. I haven't tried anything but clj/cljs. Notably, clj works totally fine with inferior-lisp as-is without this code. So I'm a bit confused by its existence.

Robert Randolph16:02:03

I thought perhaps it was a workaround for joker, lumo or planck. I have not tested (nor do I care to)

dpsutton17:02:23

@audiolabs if you create an issue and assign it to dpsutton i can dig a bit through these

Robert Randolph17:02:43

@dpsutton unable to assign, but issue is above ^

bozhidar17:02:08

> Notably, clj works totally fine with inferior-lisp as-is without this code. So I'm a bit confused by its existence. (edited)

bozhidar17:02:39

It's possible that something has changed, but I'm pretty sure this didn't work properly in the past.

bozhidar17:02:18

This was the original problem this was supposed to address https://github.com/clojure-emacs/inf-clojure/issues/7

Robert Randolph18:02:57

It does not appear to be an issue with latest clojure, macOS 11.1 and emacs 27.1, at least.

Robert Randolph18:02:47

I did quickly check in emacs 26.3 and macOS catalina, with no issues noted. No clojure <1.10 tested.

Robert Randolph18:02:33

I suspect maybe there was a change to a comint-input-filter somewhere between now and 2015?

bozhidar18:02:36

Perhaps comint handles such cases differently today. I'd be happy to remove this if it's no longer needed.

Robert Randolph18:02:27

well, I have about 90 hours of using inf-clojure with that code removed under the conditions listed above 😉

Robert Randolph18:02:55

I don't know how well that may translate to other environments or versions

bozhidar18:02:09

When in doubt - delete first and check if someone complains later. 😄 This has historically worked pretty well for me.

😂 3
✔️ 6
richiardiandrea20:02:24

Hey just answered to the above if - I like the ☝️ take - my patch was working for everything I tried except lumo