Fork me on GitHub
#immutant
<
2018-02-06
>
ikitommi05:02:35

@tcrawley oops, I was thinking else than writing, so these break: - all custom response handling extensions break (as the multimethod doesn't exist anymore, fails most likely at compile time, which is good) - some middleware might break as the request doesn't auto-deref Delays as before. It was an implementation detail, so I guess it's ok.

ikitommi05:02:47

I could also add support to async-ring, via an option like :async? (same as Jetty has).

ikitommi05:02:47

Also, tempted to autoformat code for default indentation, but it's your codebase, so only if you think it's ok.

laujensen08:02:49

Whats changed from 1.1.4 to 2.x in terms of wrap-params? Im seeing it work in some cases where it did before, and in other cases it breaks and I have to slurp the body.