Fork me on GitHub
#immutant
<
2017-06-21
>
tcrawley01:06:53

@donyorm what is webjars-locator-jboss-vfs? And are your dependency trees the same for boot and lein?

tcrawley01:06:37

can you share the output of lein deps :tree and the equivalent in boot (I think it is boot show -d maybe?)

donyorm13:06:35

@tcrawley lein deps :tree outputs:

donyorm17:06:13

@tcrawley the dependencies should be the same. webjars-locator-jboss-vfs is a (possibly optional) dependency of immuntant as far as I know. It's part of a luminus project

donyorm17:06:34

yogthos sent me here with this question

tcrawley17:06:51

@donyorm webjars-locator-jboss-vfs isn't a dep from immutant, I don't know where it comes from. And you should only need it when deploying an Immutant app to WildFly, as that's the only place where vfs will exist.

tcrawley17:06:07

can you share the app where you see this problem? and when does the error manifest?

donyorm17:06:29

@tcrawley the app is a standard luminus project (created with lein new luminus app-name) but I'm trying to make it run under boot. The error only manifests when I run the app with boot. I'll try and get the project on github

donyorm17:06:29

obviously build.boot and project.clj contain the most relevant items

donyorm17:06:43

you can run the project under boot with boot dev run

tcrawley18:06:10

cool, thanks. I'll take a look

donyorm18:06:22

thanks for helping me with this. It's a weird (and frustrating) issue

tcrawley18:06:26

are you trying to get a specific Luminus app working with boot, or just trying to solve the case generally? If it's the former, a quick solution is to remove that dependency if you aren't going to be deploying to WildFly. I think the proper answer is only include that dep when building an Immutant war file. I think we have provisions for that in the plugins.

tcrawley18:06:49

But that doesn't identify why you see the error with one tool and not the other

tcrawley18:06:42

and lein isn't

donyorm18:06:02

I'm trying to get luminus working with boot

donyorm18:06:18

so I need to figure out how to solve the issue with the dependncy in place

tcrawley18:06:11

I don't think the dependency should be there though - it should only be in a profile that gets applied when you are building an immutant war file, because it has no value outside of WildFly

tcrawley18:06:24

so I think luminus itself needs to change there

donyorm18:06:37

I'll ask on that channel

tcrawley18:06:51

I'll join there

donyorm18:06:49

give me a sec to ask, I'm in the middle of something

tcrawley18:06:07

sure, no problem. I'll just observe at first :)

tcrawley19:06:37

Ah, yeah. That code is using ServiceLoader to search the classpath for UrlProtocolHandler service definitions, which finds the one in webjars-locator-jboss-vfs, which triggers registration of it

tcrawley19:06:52

but I have no idea why that code doesn't get triggered under lein

donyorm19:06:21

it's definetely weird

donyorm19:06:03

welp, I figured out that error

donyorm19:06:53

for some reason, [org.webjars/webjars-locator-core "0.27"] was causing issues. When I excluded it from a different dependency it kind started working. Now I have another error 🙂