Clojurians Log v2

just adding a link - https://github.com/sunng87/ring-jetty9-adapter/commits/master/ as of April 7, 3 days ago. Note, this is a Jetty12 adapter despite the very confusing name

can you give me the background - there are so many versions to keep track of so help me load context

what were you on before, what happened, i assume you are upgrading now, why now, which version did we support

Electric is version v2-alpha-540-ga4699532, being used with ring 1.13.0. I am now updating ring to 1.14.1 in order to pull in an updated Jetty (`12.0.18`) to fix security vulnerabilities.

So Jetty is changing from v11->12 and all the classes changed 😅

in v2 our ring adapter targetted jetty 11 transitively via ring 1.13 ?

I believe so yes

is this due to Jetty 11 EOL announcement

Not specifically. Initially triggered by some dependabot security vulnerabilities flagged

But that would also be a good reason to upgrade

i need to talk to the team, i don't think we've done this yet for electric v3 even, the jetty 11 EOL announcement was very sudden

Ok great thanks. So does that mean at the moment, it's unlikely v2 works with jetty 12?

I see https://github.com/ring-clojure/ring/blob/master/CHANGELOG.md#1140-2025-03-25 was released two weeks ago

Oh ha I didn't realise it was so recent

I dont know if we support it, iiuc we depend on ring's API so if ring didn't change maybe it is fine?

i also have the v3 ring adapters in mind, the v2 ones may be different

Ok, I'll carry on seeing if I can work out how to configure the websocket config and see where I get to. Thanks

We will log a ticket internally, but it may be ... several weeks ... before we get to it

No problem