you’re losing a custom binding on reconnect?

yeah. and when it does connect I get this error in browser console:

_LT_x is undefined

 in (try ...) 

 TypeError: _LT_x is undefined
    with runtime.cljc:601
    iterator Continuous.cljs:144
    missionary$impl$Continuous$suspend missionary.impl.Continuous.js:487
    missionary$impl$Fiber$Fiber$swich$arity$2 Continuous.cljs:16
    missionary$core$switch core.cljc:165
    hyperfiddle$electric$impl$runtime$variable_$_cr159841_block_3 runtime.cljc:619
    result impl.cljc:60
core.cljs:3953:14
    cljs$core$IFn$_invoke$arity$5 core.cljs:3953
    cljs$core$IFn$_invoke$arity$4 core.cljs:3948
    cljs$core$IFn$_invoke$arity$3 core.cljs:3942
    cljs$core$IFn$_invoke$arity$2 core.cljs:3936
    cljs$core$IFn$_invoke$arity$2 core.cljs:3971
    G__160034__delegate runtime.cljc:86
    G__160034 hyperfiddle.electric.impl.runtime.js:71
    1 Latest.cljs:34
    missionary$impl$Latest$transfer missionary.impl.Latest.js:148
    cljs$core$IDeref$_deref$arity$1 Latest.cljs:10
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    1 Latest.cljs:28
    missionary$impl$Latest$transfer missionary.impl.Latest.js:148
    cljs$core$IDeref$_deref$arity$1 Latest.cljs:10
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    1 Latest.cljs:28
    missionary$impl$Latest$transfer missionary.impl.Latest.js:148
    cljs$core$IDeref$_deref$arity$1 Latest.cljs:10
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    1 Latest.cljs:28
    missionary$impl$Latest$transfer missionary.impl.Latest.js:148
    cljs$core$IDeref$_deref$arity$1 Latest.cljs:10
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    1 Latest.cljs:28
    missionary$impl$Latest$transfer missionary.impl.Latest.js:148
    cljs$core$IDeref$_deref$arity$1 Latest.cljs:10
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    cljs$core$IDeref$_deref$arity$1 runtime.cljc:547
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    hyperfiddle$electric$impl$yield2$transfer_loop yield2.cljc:30
    hyperfiddle$electric$impl$yield2$transfer_recover yield2.cljc:31
    out yield2.cljc:37
    hyperfiddle$electric$impl$yield2$transfer_input hyperfiddle.electric.impl.yield2.js:231
    hyperfiddle$electric$impl$yield2$transfer yield2.cljc:42
    cljs$core$IDeref$_deref$arity$1 yield2.cljc:13
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    value Continuous.cljs:179
    missionary$impl$Continuous$push missionary.impl.Continuous.js:565
    missionary$impl$Fiber$Fiber$unpark$arity$1 Continuous.cljs:18
    missionary$core$unpark core.cljc:172
    hyperfiddle$electric$impl$runtime$variable_$_cr159841_block_4 runtime.cljc:619
    result impl.cljc:60
    G__159181__0 cloroutine.impl.js:45
    r Continuous.cljs:74
    missionary$impl$Continuous$step missionary.impl.Continuous.js:321
    1 Continuous.cljs:205
    missionary$impl$Continuous$transfer missionary.impl.Continuous.js:614
    cljs$core$IDeref$_deref$arity$1 Continuous.cljs:12
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    missionary$impl$Reactor$pull Reactor.cljs:87
    missionary$impl$Reactor$sample Reactor.cljs:98
    value Reactor.cljs:258
    missionary$impl$Reactor$push missionary.impl.Reactor.js:768
    cljs$core$IDeref$_deref$arity$1 Reactor.cljs:16
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    1 Latest.cljs:28
    missionary$impl$Latest$transfer missionary.impl.Latest.js:148
    cljs$core$IDeref$_deref$arity$1 Latest.cljs:10
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    1 Latest.cljs:28
    missionary$impl$Latest$transfer missionary.impl.Latest.js:148
    cljs$core$IDeref$_deref$arity$1 Latest.cljs:10
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    1 Latest.cljs:28
    missionary$impl$Latest$transfer missionary.impl.Latest.js:148
    cljs$core$IDeref$_deref$arity$1 Latest.cljs:10
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    missionary$impl$Reactor$pull Reactor.cljs:87
    missionary$impl$Reactor$touch Reactor.cljs:120
    missionary$impl$Reactor$publish Reactor.cljs:347
    missionary$core$stream_BANG_ core.cljc:885
    _rec__3 runtime.cljc:786
    iterator Reactor.cljs:341
    missionary$impl$Reactor$publish missionary.impl.Reactor.js:1064
    missionary$core$stream_BANG_ core.cljc:885
    _rec__3 runtime.cljc:779
    cljs$core$IDeref$_deref$arity$1 Reactor.cljs:312
    cljs$core$_deref core.cljs:688
    cljs$core$deref core.cljs:1477
    missionary$impl$Reactor$pull Reactor.cljs:87
    missionary$impl$Reactor$sample Reactor.cljs:98
    missionary$impl$Reactor$touch Reactor.cljs:123
    missionary$impl$Reactor$propagate Reactor.cljs:137
    missionary$impl$Reactor$event Reactor.cljs:281
    missionary$impl$Reactor$run Reactor.cljs:316
    reactor_call core.cljc:870
    iterator Ambiguous.cljs:320
    missionary$impl$Ambiguous$suspend missionary.impl.Ambiguous.js:910
    missionary$impl$Fiber$Fiber$park$arity$2 Ambiguous.cljs:16
    missionary$core$park core.cljc:162
    cr112668_place_22 electric_client.cljs:108
    result impl.cljc:60
    G__159181__0 cloroutine.impl.js:45
    x Ambiguous.cljs:262
    missionary$impl$Ambiguous$ready missionary.impl.Ambiguous.js:689
    missionary$impl$Ambiguous$boot Ambiguous.cljs:28
    G__159181__2 impl.cljc:64
    missionary$impl$Ambiguous$backtrack Ambiguous.cljs:34
    missionary$impl$Ambiguous$branch Ambiguous.cljs:73
    missionary$impl$Ambiguous$ready Ambiguous.cljs:307
    missionary$impl$Ambiguous$boot Ambiguous.cljs:28
    missionary$impl$Ambiguous$run Ambiguous.cljs:358
    missionary$core$ap_run core.cljc:178
    G__159181__3 impl.cljc:65
    G__52817__2 core.cljs:4358
    iterator Ambiguous.cljs:320
    missionary$impl$Ambiguous$suspend missionary.impl.Ambiguous.js:910
    missionary$impl$Fiber$Fiber$fork$arity$3 Ambiguous.cljs:18
    missionary$core$fork core.cljc:169
    hyperfiddle$electric_client$send_all_$_cr112559_block_0 electric_client.cljs:65
    result impl.cljc:60
    G__159181__0 cloroutine.impl.js:45
    x Ambiguous.cljs:262
    missionary$impl$Ambiguous$ready missionary.impl.Ambiguous.js:689
    missionary$impl$Ambiguous$boot Ambiguous.cljs:28
    missionary$impl$Ambiguous$run Ambiguous.cljs:358
    missionary$core$ap_run core.cljc:178
    G__159181__3 impl.cljc:65
    G__52817__2 core.cljs:4358
    input Reduce.cljs:36
    missionary$impl$Reduce$run missionary.impl.Reduce.js:128
    2 core.cljc:524
    missionary$impl$race_join/j.cancel[index_157112]< impl.cljs:179
    missionary$impl$race_join missionary.impl.js:613
    variadic core.cljc:115
    c_156678 Sequential.cljs:29
    missionary$impl$Sequential$suspend missionary.impl.Sequential.js:134
    missionary$impl$Fiber$Fiber$park$arity$2 Sequential.cljs:13
    missionary$core$park core.cljc:162
    hyperfiddle$electric_client$connector_$_cr112581_block_3 electric_client.cljs:74
    result impl.cljc:60
    G__159181__0 cloroutine.impl.js:45
    x_156679 Sequential.cljs:40
    missionary$impl$Sequential$step missionary.impl.Sequential.js:151
    resume Sequential.cljs:53
    onopen electric_client.cljs:32

for context, i'm writing a use-electric react hook

can you send me a gist of what you have? it can be sloppy

i’m headed to bed but we will look tomorrow

just this bit https://gist.github.com/nivekuil/a839c346eedb2b73f54fcc24dbdad9a1

ok, i see how you’re setting the binding, i need to read the src, don’t remember how it works, we will get back to you

thanks, also for further context I need to override the endpoint because I'm just using the provided jetty server alongside my existing http server. But I also think it'd be really cool to spin up electric instances dynamically

I want to use electric more surgically for latency-critical multiplayer use cases and have a bunch of electric clients embedded in react

@U797MAJ8M this snippet works the first time, it is only reconnect that loses the dynamic?

which makes sense, ok

If I am not mistaken, you can (set! ws-server-url ...) at top level

Upon review of the history I think I do consider this a bug, we should capture the binding set at boot, though we are unlikely to fix it soon unless you can't get it to work

cool, I can connect so that's not an immediate problem. The error I get after that is weird though. It looks like runtime/with is scheduled in a callback, and when it's fired the second arity <x is undefined?

this stuff is really opaque to troubleshoot

i dont understand, was there progress or did i send bad guidance

and are you saying the binding is intermittently available? sometimes it reconnects?

i think maybe i need to clone your repo

I'm referring to the stacktrace I sent above

should make a separate thread maybe

but after it connects, nothing is happening except for that error in the console

i've desynced from you, can you state the issue from the beginning without referring to any prior context

Are you still customizing ws-server-url in this way?

@U09K620SG it looks like I just did (set! hyperfiddle.electric-client/*ws-server-url* "") , but I think that isn't good enough for something like a per-component endpoint

there's ui/select which is used in the https://github.com/hyperfiddle/electric/blob/b5a86efe63d456131cb5fd953ee6f8ae9e029427/src-docs/user/demo_virtual_scroll.cljc#L67. We did not wrap radio pickers yet since using the typeahead and select was fine for our use cases. Your w3schools example would be built in electric

(dom/form
  (dom/input (dom/props {:type "radio" ...

Okay thank you so much and I am sorry my repo clone is a little old so I didn't see that example in mine. :)

Have a good day! 🙂

Are you getting any error printed to your REPL or javascript console?

no, nothing in either place. I can push up a fork of the repo if you are interested

Yes, please

https://github.com/AdamFrey/electric-starter-app Thank you for your help!

Thank you, I’ll give it a look

I’m short on time to look into it today, sorry. I’ll get back to you

no problem. Thanks, again

We can reproduce the issue and also saw it elsewhere. Probably not related to shadow-css. This is on us, we’ll keep you posted.

Hi @U06060CK0, we landed a fix where I've seen similar behavior and now it's gone. If you pull latest master and still find this behavior can you let us know?

it appears that on d636c0f I am still able to reproduce the behavior I was seeing. I actually pared down the reproduction steps to trigger the behavior in the README on my fork of the starter app. https://github.com/AdamFrey/electric-starter-app

@U06060CK0 we pushed a fix for this, I also tested your repro steps with latest master commit and can no longer reproduce

awesome. I pulled the latest commit and am also confirming that it's fixed on my end. Thank you!

It looks like runtime/with is scheduled in a callback, and when it's fired the second arity <x is undefined

I get a similar error from (e/client (new nil))

yeah, but the (.-current ref) shouldn't be nil as it's in a if.. statement (see gist from last thread)

https://gist.github.com/nivekuil/a839c346eedb2b73f54fcc24dbdad9a1

the string ".-current ref" is not in the gist

Passing electric-component through a clojure function is suspicious

(defn start-electric [dom-root-ref electric-component]
  (hooks/use-effect (fn []
                      (if-let [x (.-current dom-root-ref)]
                        (let [electric-main (e/boot (electric-component. x))
                              reactor       (electric-main
                                             #(js/console.log "Reactor success:" %)
                                             (fn [error]
                                               (case (:hyperfiddle.electric/type (ex-data error))
                                                 :hyperfiddle.electric-client/stale-client (do (js/console.log "Server and client version mismatch. Refreshing page.")
                                                                                               (.reload (.-location js/window)))
                                                 (js/console.error "Reactor failure:" error))))]
                          #(reactor))
                        js/undefined))
                    [dom-root]))

what should be I be doing instead of passing that?

can you hardcode it and see if it works

can i see the intended usage of (start-electric ...)

it does

but what exactly is happening when I pass electric-component?

(e/def x ...) from clojure-land's perspective, macroexpands to (def x) and then adds the quoted electric expr as metadata

so electric-component is nil, clojure resolved it as a clojure var to nil

why is (meta Main) nil?

(meta #'Main)

ahh

also see defmacro def in electric.cljc

To solve this, if you need to parameterize the electric entrypoint, i think you can use defmacro

you attach it to the var, I see. forgot that was a thing you could do

Also see https://github.com/hyperfiddle/electric/blob/1bdd53bce5b5a2ebf69ac25bc5ae9eb564be692f/src-dev/user_main.cljc#L95

page here is a qualified symbol to an electric def, which is resolved in Pages earlier in the file

the code is contorted because Electric does not have eval yet, and basically the electric compiler today drops any electric code that isn't reachable from the entrypoint

so if you wanna be dynamic, you can use a symbol but it needs to be a static reference, if that makes sense, vocabulary is escaping me right now

i gtg - sorry about the pain

I will log a ticket to improve that error about >x is nil, that was really bad

no worries, this is definitely challenging some assumptions I have about clojure

haha in what way

I never write macros, I think I use metadata for one system but that was IMO a mistake. I think just using qualified kws for everything in as global a scope as possible is the way to go

so I rarely have to think outside the "everything I care about is in the map of kw->whatever" mindset

blame pathom, makes programming ez mode

yeah i agree with you that clojure's metadata is not broadly useful, it's almost useful in so many situations

hopefully we can reduce the macro pain as Electric matures. The particular issue you hit today probably can be solved in a future design

or

(e/defn Test []
  (e.d/text "hi"))

(e/defn Main [dom-root]
  (binding [e.d/node dom-root]
    (e/server (new (Test.)))))

oh, I guess it has to be like this

(e/defn Test []
  (e/client (e.d/text "hi")))

(e/defn Main [dom-root]
  (binding [e.d/node dom-root]
    (e/server (new (Test.)))))

the error “cannot resolve dom/node” means accessed from the wrong side

if the e/client or e/server is omitted, it is inherited from the caller

Figured this out with styles:

(ui/button (e/fn [] (do-something))
  (dom/style {:background "transparent"
              :border 0})
  (svg/svg ...))

i don’t know the answer to this, i would start with stackoverflow probably to find out how it ought to work and then we can figure out how to do it in electric

(svg/svg
  (dom/on "click" (e/fn [event] (prn "svg clicked")))
  (svg/rect
    (dom/on "click" (e/fn [event] (prn "rect clicked")))))

((fn [] (prn 1) (prn 2))) will fuse the effects, because clojure functions aren’t reactive inside. we could provide a macro for that ‘e/fuse’ but like you we have not found a real use case, each time we reached for it so far it turned out to not be the best option