Fork me on GitHub
#hoplon
<
2018-01-03
>
flyboarder00:01:39

@thedavidmeister sure, so in your PR #222, if we remove mksingleton we will break prerendering, as the element will re-render it’s content

flyboarder00:01:37

there is a check in mksingleton that only add’s children when the :static attribute is false (default when missing)

thedavidmeister01:01:44

@flyboarder ok, i'll split this in two parts then

thedavidmeister01:01:00

7.2 i'll just move the body creation into call time for the body fn

thedavidmeister01:01:55

7.3+ i'll look into whether prerendering can be handled so that body and head work like other els

flyboarder01:01:22

@thedavidmeister sounds good! So close to another release with better stability for 3rd party!

flyboarder01:01:04

@thedavidmeister also if there is anything else reporting issues in your staging builds I’d like to get that fixed asap

flyboarder01:01:30

⚠️ For anyone tracking the 7.2 progress, this should be 100% compatible with 7.0 and 7.1 provided you are not using experimental features. ⚠️

flyboarder04:01:52

@thedavidmeister the more I think about the body elem thing, the more I think we should fix this in the tests, not core, since it’s a platform bug and so far only exists on phantom

thedavidmeister08:01:24

@flyboarder i don't think that's quite right, i think it's just that document.body is technically optional

thedavidmeister08:01:39

we'll just move the check to when body is called and it should be OK

thedavidmeister08:01:16

pretty sure that you could pass <html><head></head></html> to chrome and it would be a valid html doc

flyboarder19:01:36

@alandipert All of the 7.2 tickets are resolved. This brings a much needed overhaul to the code base which removes prototype overrides, cleans up dead code and moves experimental features to hoplon/brew repo. All of the core code is documented and organized into sections within the code. I have requested your review on github.

alandipert19:01:46

flyboarder sounds amazing. i'll take a look later today

flyboarder22:01:30

Is anyone else able to test 7.2.0-SNAPSHOT

flyboarder22:01:12

All 7.* versions should be compatible, except for anything marked experimental

flyboarder23:01:40

@thedavidmeister has the 7.2 version gotten passed your staging tests?