Fork me on GitHub
#hoplon
<
2017-12-23
>
thedavidmeister00:12:19

hmmm, can we also move the experimental stuff into a new ns in 7.2+?

flyboarder00:12:44

yes, thats better than what I had in mind which was to pull it entirely

flyboarder00:12:51

we need a change log also πŸ˜›

thedavidmeister01:12:03

we could pull it and move to a different repo

thedavidmeister01:12:27

i haven't personally used the experimental stuff so i don't really know much about it

flyboarder02:12:36

it would fit inline more within hoplon/brew

flyboarder02:12:22

really hoplon.core should be all the stable ancient code πŸ™

thedavidmeister02:12:01

yeah, less is more i think

thedavidmeister03:12:50

so i think the simplified but more consistent logic for these fns should just be "use managed version if parent is already managed or any child is a cell, else use native prototype fn"

thedavidmeister04:12:53

in my branch all the overrides now look something like this

thedavidmeister04:12:57

(defn- set-appendChild!
  [this kidfn]
  (set! (.-appendChild this)
        (fn [child]
         (this-as this
          (if (or (managed? this) (cell? child))
           (managed-append-child this child kidfn)
           (.call appendChild this child))))))

thedavidmeister07:12:33

@flyboarder i'm finding lots of edge cases here >.< that refactor is looking more and more attractive

thedavidmeister07:12:08

i suspect that in the refactor that insertBefore and replaceChild overrides can just be immediately deleted - they don't seem to work for cells and aren't currently used for anything internally AFAICS

flyboarder18:12:49

Ok everyone, im going to press the big button……. any last objections!?

flyboarder19:12:12

πŸŽ‰ It has been done [hoplon/hoplon "7.1.0"] is on Clojars! πŸŽ‰

flyboarder19:12:54

A 🎁 from @thedavidmeister and myself πŸ™‚

alandipert19:12:32

this is great news, thank you and congratulations!