Fork me on GitHub
#hoplon
<
2017-10-10
>
daemianmack00:10:54

meta-j22 /buffer *22

daemianmack00:10:19

whoops, damn keybinding :)

thedavidmeister02:10:50

@flyboarder i was worried about dupes of tests if we have two folders

thedavidmeister02:10:01

ideally we would test everything in both configurations

thedavidmeister02:10:22

is there a way to dynamically set namespace dependencies somehow?

flyboarder04:10:43

@thedavidmeister well we can call (require) can’t we? Maybe call the tests twice? with a compiler flag set for which namespace to use?

flyboarder04:10:57

just brainstorming

thedavidmeister04:10:24

@flyboarder i thought you can't call require directly in cljs? 😞

thedavidmeister04:10:35

that's exactly what i want to do

thedavidmeister04:10:42

run the tests twice with a compiler flag

thedavidmeister04:10:54

i just don't know exactly what that looks like

thedavidmeister04:10:00

@flyboarder ok, i've used goog-define instead of regular def

thedavidmeister04:10:11

but not for anything in the ns layer

flyboarder04:10:45

@thedavidmeister I think it should work the same, then we need to update the test runner

thedavidmeister04:10:45

but then i know that cljc works in ns

thedavidmeister04:10:48

so it must be possible

thedavidmeister04:10:16

well maybe we should do this in two steps?

thedavidmeister04:10:28

first would be to get the existing tests all passing in both jquery and google

thedavidmeister04:10:31

then we can add new tests

thedavidmeister04:10:50

i actually doubt everything we currently have will pass on the first try

thedavidmeister04:10:49

there's enough tests there that something will probably not quite line up exactly

thedavidmeister04:10:07

i don't know how often anyone actually compares the output of jquery/google by hand

flyboarder15:10:41

@thedavidmeister yeah there will probably be things to fix right away XD