Fork me on GitHub
#hoplon
<
2017-08-27
>
thedavidmeister01:08:14

@flyboarder should we just move to 908 then?

thedavidmeister01:08:23

sounds like something that was broken and then fixed again in cljs itself?

flyboarder01:08:07

@thedavidmeister yep it's running on my unit, however tests fail until boot-cljs-tests gets fixed

thedavidmeister01:08:05

does :process-shim false work?

flyboarder01:08:48

not sure, I believe it should, but my projects build with 908

thedavidmeister01:08:08

you'd either pass it to :doo-opts or :cljs-opts in boot-cljs-test

thedavidmeister01:08:47

oh ok, can you push 908 up to the snapshot branch so we can review?

flyboarder02:08:52

@thedavidmeister it’s already the current clojars snapshot

flyboarder02:08:29

ill push with updated boot-cljs

thedavidmeister02:08:43

ok, i'm going to push a couple more tests up in a sec

flyboarder02:08:02

sounds good 🙂

thedavidmeister02:08:47

just covering off what i was discussing in cljs chat the other day

thedavidmeister02:08:43

it's failing on my local with the doo thing as well

flyboarder02:08:52

yeah, checking task opts

thedavidmeister02:08:49

(test-cljs :cljs-opts {:process-shim false}) works

thedavidmeister02:08:14

how do i get that to work with replace-task!?

flyboarder02:08:56

dont need to

flyboarder02:08:43

oh i see what you mean

thedavidmeister02:08:17

i think i have a fix

flyboarder02:08:05

:thumbsup: should be able to just join them to the list

thedavidmeister02:08:47

apparently i can even just stick them inline

thedavidmeister02:08:26

cool, so hoplon 100% up to date with cljs

thedavidmeister02:08:15

@flyboarder is there anything else needed for 7.1.0? or is it just waiting on cljs 1.9 to be released now?

flyboarder03:08:51

I would like to implement a attribute lookup for keywords on elements, 3rd party libs do store state in elements even tho we might not

flyboarder03:08:05

i also think we could organize core better, move protocols to their own namespace, I think this would also help with newcomers learning how hoplon works

thedavidmeister03:08:36

want me to push a test for keyword lookups?

flyboarder03:08:25

we could also go through and make sure we have everything tested/spec’ed

thedavidmeister03:08:49

there's no such thing as "everything tested" 😛

thedavidmeister03:08:07

but if you have some requests we can look at it 🙂

flyboarder03:08:05

well i’d like to get spec’s working for the signature of invoking an element so you cant do this (div :my-attr true :my-other-attr) and forget the attribute value

flyboarder03:08:15

awesome test!

thedavidmeister03:08:54

what do you mean about forgetting attribute values?

flyboarder03:08:34

for example when an attribute is a bool and an element has many of these, a common thing I see is myself forgetting to add true to the attribute

flyboarder03:08:24

im not sure if we can really check for this but…

thedavidmeister03:08:47

i haven't tried this, but does (div #{:my-attr :my-other-attr}) work?

thedavidmeister04:08:09

sets have dupe k/v

flyboarder04:08:11

are sets just like body tho

flyboarder04:08:30

I could be wrong

thedavidmeister04:08:42

do you mean as a child?

flyboarder04:08:04

that what I figured happens since they are a list

thedavidmeister04:08:15

well no, they aren't

flyboarder04:08:16

i dont think I have ever tried that

thedavidmeister04:08:20

because they don't have an order

thedavidmeister04:08:25

they're not sequential

thedavidmeister04:08:40

i think of them more like maps where the keys and values are always the same

flyboarder04:08:48

sorry “collection”

thedavidmeister04:08:05

i don't think it is safe to treat anything that isn't sequential as body

thedavidmeister04:08:10

because the ordering is not reliable

flyboarder04:08:33

maybe a test for sets then?

flyboarder04:08:04

we should probably test what happens with each data type for collections

flyboarder04:08:35

Just In Case ™️

thedavidmeister04:08:13

yeah putting something up

thedavidmeister04:08:13

here's a few examples

thedavidmeister04:08:31

currently doesn't get past the first example, #object[Object Error: NotFoundError: DOM Exception 8]

thedavidmeister04:08:41

likely due to sets being treated as children

flyboarder18:08:05

@thedavidmeister squashing those test errors 😉