doo#141

@flyboarder should we just move to 908 then?

sounds like something that was broken and then fixed again in cljs itself?

@thedavidmeister yep it's running on my unit, however tests fail until boot-cljs-tests gets fixed

https://github.com/crisptrutski/boot-cljs-test/issues/67

does :process-shim false work?

not sure, I believe it should, but my projects build with 908

you'd either pass it to :doo-opts or :cljs-opts in boot-cljs-test

oh ok, can you push 908 up to the snapshot branch so we can review?

@thedavidmeister it’s already the current clojars snapshot

ill push with updated boot-cljs

ok, i'm going to push a couple more tests up in a sec

sounds good 🙂

just covering off what i was discussing in cljs chat the other day

it's failing on my local with the doo thing as well

yeah, checking task opts

(test-cljs :cljs-opts {:process-shim false}) works

how do i get that to work with replace-task!?

dont need to

oh i see what you mean

here

i think i have a fix

:thumbsup: should be able to just join them to the list

apparently i can even just stick them inline

https://github.com/boot-clj/boot/blob/cb923ee78ada4ade6ec60782f4b3b1762325ce30/boot/core/src/boot/core.clj#L1121

slick

yay, all green

cool, so hoplon 100% up to date with cljs

@flyboarder is there anything else needed for 7.1.0? or is it just waiting on cljs 1.9 to be released now?

I would like to implement a attribute lookup for keywords on elements, 3rd party libs do store state in elements even tho we might not

i also think we could organize core better, move protocols to their own namespace, I think this would also help with newcomers learning how hoplon works

want me to push a test for keyword lookups?

sure

we could also go through and make sure we have everything tested/spec’ed

there's no such thing as "everything tested" 😛

but if you have some requests we can look at it 🙂

does this work as a test? https://github.com/hoplon/hoplon/pull/199/commits/6dc3f74eb138ede923aa6307649d656f2eb91b5d

well i’d like to get spec’s working for the signature of invoking an element so you cant do this (div :my-attr true :my-other-attr) and forget the attribute value

awesome test!

what do you mean about forgetting attribute values?

for example when an attribute is a bool and an element has many of these, a common thing I see is myself forgetting to add true to the attribute

hmm i see

im not sure if we can really check for this but…

i haven't tried this, but does (div #{:my-attr :my-other-attr}) work?

maybe?

sets have dupe k/v

are sets just like body tho

I could be wrong

do you mean as a child?

yeah

hmm, not sure

that what I figured happens since they are a list

well no, they aren't

i dont think I have ever tried that

because they don't have an order

they're not sequential

i think of them more like maps where the keys and values are always the same

sorry “collection”

i don't think it is safe to treat anything that isn't sequential as body

because the ordering is not reliable

good point

maybe a test for sets then?

😛

we should probably test what happens with each data type for collections

Just In Case ™️

yeah putting something up

@flyboarder https://github.com/hoplon/hoplon/pull/199/commits/848acab94902bba2bd797af336a5a489e00803d3

here's a few examples

currently doesn't get past the first example, #object[Object Error: NotFoundError: DOM Exception 8]

likely due to sets being treated as children

@thedavidmeister squashing those test errors 😉