This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-08-22
Channels
- # beginners (143)
- # boot (18)
- # chestnut (5)
- # clara (1)
- # cljs-experience (1)
- # cljsrn (13)
- # clojure (290)
- # clojure-austin (4)
- # clojure-italy (13)
- # clojure-nl (21)
- # clojure-russia (14)
- # clojure-spec (49)
- # clojure-uk (59)
- # clojurebridge (7)
- # clojurescript (54)
- # core-logic (2)
- # cursive (22)
- # datomic (149)
- # fulcro (31)
- # graphql (14)
- # hoplon (59)
- # keechma (24)
- # lambdaisland (1)
- # lumo (86)
- # off-topic (3)
- # om (19)
- # om-next (1)
- # onyx (4)
- # portkey (20)
- # re-frame (41)
- # reagent (63)
- # ring (1)
- # ring-swagger (1)
- # spacemacs (9)
- # sql (10)
- # yada (13)
@flyboarder nice, did you push to clojars?
@thedavidmeister probably not….. ill do it again anyway
oh looks like I did
i'll re-run my tests then 🙂
also just finished the new website, entirely in Hoplon
also, getting fails for this now
(h/defelem section
[{:keys [left
right
left-colour
left-text-colour
right-colour
right-text-colour
children
padding
id]}]
i'll see if i can get a test up
@flyboarder you definitely pushed to clojars?
i'm struggling to reproduce this one a bit
clojure.lang.ExceptionInfo: clojure.lang.ExceptionInfo: ERROR: Call to hoplon.core/elem did not conform to spec:
In: [0] val: [{:keys [left right left-colour left-text-colour right-colour right-text-colour children padding id]}] fails spec: :hoplon.spec/attr-kids at: [:args :bindings] predicate: (= (count %) 2)
:clojure.spec.alpha/args ([{:keys [left right left-colour left-text-colour right-colour right-text-colour children padding id]}] (let [padding (or padding (u/px 70))] [(h/div :class "two-col-wrapper" :id id (h/div :class "lefty" :garden {:background-color left-colour, :color right-text-colour, :padding padding} left) (h/div :class "righty" :garden {:background-color right-colour, :color right-text-colour, :padding padding} (into children right)))]))
@thedavidmeister gimme 2 minutes and I'll push again
also, i think my section element is screwed up anyway
i dunno why children
is in keys
lol
Should be good now
yes thanks 🙂
next error
clojure.lang.ExceptionInfo: clojure.lang.ExceptionInfo: ERROR: Call to hoplon.core/for-tpl did not conform to spec:
In: [0 0] val: [k label placeholder] fails spec: :hoplon.spec/binding-cell at: [:args :bindings 0] predicate: symbol?
:clojure.spec.alpha/args ([[k label placeholder] [[:item/title "Item name:" "Name this item…"] [:item/min "Minimum:" "Minimum"] [:item/max "Maximum:" "Maximum"] [:item/mode "Most likely:" "Most likely"]]] (form.hoplon/item-input :focus (j/cell= (and focus? show-fields? (= :item/title k))) :item-key k :item item :placeholder placeholder :input (fn* [p1__50291#] (item.api/user-input! conn (merge (clojure.core/deref item) {(clojure.core/deref k) (clojure.core/deref p1__50291#)})))))
looks to be caused by me passing a sequence instead of a cell to for-tpl
@flyboarder https://github.com/hoplon/hoplon/pull/199/files#diff-c005ffe651ac63a804bd12fdd9cb0ad9R20 new tests 🙂
@thedavidmeister updated!
travis #325 should pass
nah it won't because i made a bad test 😛
any idea how to get java.io.NotSerializableException: clojure.spec.alpha$regex_spec_impl$reify__1200
to output the actual spec error?
could It mean an issue with the spec itself?
i dunno, it's just the output of the test that means something is failing a spec
very unhelpful
@flyboarder through trial and error i figured out that it's failing on
(let [c (j/cell [1 2 3])
el (h/div
(h/for-tpl [t c]))]))
@thedavidmeister im getting this
WARNING: doo's init function was not set
#object[TypeError TypeError: undefined is not an object (evaluating 'hoplon.tpl_test._QMARK__QMARK_if_tpl')]
just means you have an error... somewhere...
lets see if this goes anywhere
nope…
kk fixed
pushing
it did not like (map .-textContent ..)
i had to wrap that in a fn
our tests are slow, I added .m2
to travis cache
pushed to clojars
oh yeah good idea on the cache
clojure.lang.ExceptionInfo: clojure.lang.ExceptionInfo: ERROR: Call to hoplon.core/for-tpl did not conform to spec:
In: [0] val: [c (j/cell= (seq padded))] fails spec: :clojure.core.specs.alpha/local-name at: [:args :bindings :binding :sym] predicate: simple-symbol?
In: [0 1] val: ((j/cell= (seq padded))) fails spec: :clojure.core.specs.alpha/seq-binding-form at: [:args :bindings :binding :seq] predicate: (cat :elems (* :clojure.core.specs.alpha/binding-form) :rest (? (cat :amp #{(quote &)} :form :clojure.core.specs.alpha/binding-form)) :as (? (cat :as #{:as} :sym :clojure.core.specs.alpha/local-name))), Extra input
In: [0 0] val: c fails spec: :clojure.core.specs.alpha/map-binding at: [:args :bindings :binding :map :mb] predicate: vector?
i think vector?
should be sequential?
hang on
(let [c (j/cell [])
el (h/div
(h/for-tpl [v (j/cell= (seq c))]
(h/div v)))])))
@flyboarder ok, the issue seems to be when you seq
something in for-tpl
and end up with nil
@flyboarder https://github.com/hoplon/hoplon/pull/199/files#diff-c005ffe651ac63a804bd12fdd9cb0ad9R45
@micha the code walking for Javelin JVM/Cljs cell hoisting is different, also the implementation of cells itself. Otherwise it all stays the same. I was having trouble with conditional compilation to cljs/self-host cljs but otherwise currently the thing works for me on the JVM and the tests pass on JVM/self-host.
Also the reified graph is pretty interesting. Now I’m using it in a way where each namespace gets a separate graph instance because I don’t need the cells between ns’es to interact. It needs more thought around cell lifecycle - creating/destroying cleanly so that the cells can be easily tested and destroyed without leaving garbage around.
@thedavidmeister still working on this, not sure why it’s throwing that
confirmed that is an issue with the spec itself
Woot! bug squashed!
@thedavidmeister on clojars!