@flyboarder great, that fixed the warnings 🙂

how do i disable spec?

it's i'm getting clojure.lang.ExceptionInfo: clojure.lang.ExceptionInfo: ERROR: Call to hoplon.core/elem did not conform to spec:

when i destructure attributes

Macro specs cannot be disabled, it's part of the compiler

@thedavidmeister I wonder if there are destructure specs in core

i dunno

but i can't upgrade hoplon atm 😞

(h/defelem section
 [{:keys [left right middle]} children]

that's throwing errors for me

i'll put a test up for you so you can see the problem @flyboarder

Cool, I can fix this right away

@flyboarder https://github.com/hoplon/hoplon/pull/199/commits/8a97bcf0ec8ce1969ccb69e25b82e3cdd5c13875

let's see how these go 🙂

ok yeah, it's definitely destructuring that spec is choking on @flyboarder

it can't handle this at all

(h/defelem div--destructured
 [{:keys [foo] :as attributes} _]
 (h/div
  :data-bar foo
  (dissoc attributes :foo)))

@thedavidmeister I found clojure core specs, using that

@flyboarder those tests passed 🙂 i'll try with main test suite again

@flyboarder actually, do you need to push to clojars first?

yep

@thedavidmeister on clojars now!

cool, i'll test it out

still failures

i'll push new tests in a sec

@flyboarder https://github.com/hoplon/hoplon/pull/199/commits/a2a02f5dd2ea6ab1932a5842ed1467f16900c68d should fail tests

when there are no children it breaks

@thedavidmeister not sure why that passes the spec, it should have at least 2 items to pass

why? lots of dom elements cannot have children

e.g. img

i suppose you could do _ in that case but hoplon actually works (or did) fine without children at all

@thedavidmeister I suppose you are correct, will hoplon break if things without a child are passed children?

why would it?

@dm3 defining a function as [attr] vs [attr kids], ill have to look at how children are passed to the element

@dm3 @thedavidmeister https://github.com/hoplon/hoplon/blob/master/src/hoplon/core.clj#L129-L133

A function of 2 arguments, as per the docs

it expands to a vararg

I think 🙂

https://github.com/hoplon/hoplon/blob/master/src/hoplon/core.cljs#L349

it does, eg. (div {:foo "bar"} (span "var...") (span "...args"))

that should fix it

fixed tests

@micha btw, not sure if you’ve looked at https://github.com/hoplon/javelin/issues/35 or https://github.com/hoplon/javelin/issues/25#issuecomment-315618275 - I’ve implemented the JVM/self-host Cljs Javelin support. Haven’t had the time to finish it up - the non-self-host Cljs build is broken 🙂 Would be great to hear if you’d accept the changes upstream in the future/what needs to be done for you to accept it.

I’m currently using the JVM Javelin to define alerting rules on top of Prometheus monitoring (and other data sources)

oh interesting

i am not surprised that macros are not portable between JVM and self-hosted CLJS

there are a lot of differences there

having a self-hosted CLJS version of javelin is awesome though

i don't know what the strategy is for self-hosted cljs though

are you using it in a project?

sorry ^^ is for @dm3