@flyboarder @alandipert @fiddlerwoaroof here we go https://github.com/hoplon/hoplon/pull/196

hmm, it appears that calling h/body anywhere in cljs tests triggers

TypeError: null is not an object (evaluating 'this$.hoplonKids = null')

@thedavidmeister look good :thumbsup:

@thedavidmeister 7.0.3 on clojars!

🎉

woo, i'll update the other PR too

im going to merge all my changes for 7.1 in the proposal branch

@thedavidmeister I'm still getting a warning "Wrong number of args (0) passed to cljs.core/atomat" about this line: https://github.com/fiddlerwoaroof/feed-archive/blob/e339cb3567eb76715c4ce3fa1fbda2db41359186/src/index.cljs.hl#L96

yes, different PR

@fiddlerwoaroof i'm just cleaning that fix up now

thanks, I guess I misread what was going on

there were two PRs 🙂

this is the one that fixes the warning https://github.com/hoplon/hoplon/pull/196

@flyboarder tests are passing on https://github.com/hoplon/hoplon/pull/196

thanks thedavidmeister flyboarder for swinging into action :-)

I’m still pulling all the changes together

@thedavidmeister can you poke at the 7.1-proposal branch and see why the new tests break?

@alandipert @thedavidmeister a summary of the spec work: https://github.com/hoplon/hoplon/wiki/Hoplon-Spec

@flyboarder i've been using spec more since we last talked about it

Wanna give the proposal branch a try?

it doesn't generate tests for you though, although you can use it to generate test data

but i think we probably want to write tests that are directly related to what the attributes are supposed to do

like, toggle should actually toggle the element, not just accept data

Yeah I think a combination of the tests you provided and spec should solve that, spec tests the data correctness and tests check the side effects

I am confident in the 7.1 version except for a few of the specs, which don't account for destructuring yet

cool, well i think that my tests/fix for the warnings in cljs 1.9.655+ should go in first

Agreed, we can fix the 655+ stuff and then I think that's a good basis for the new functionality

That gets tests working in 7.0.3 and cljs deps in 7.0.4

yeah

i can also make sure there are tests in place for the changes to multi-arity functions

that wasn't throwing warnings in 655 but i think it does in 660

660 throws the variadic invoke thing, so we may want to solve both of those at once

It's part of 7.1-proposal if you want to look at the code, basically we implement the correct signature and call a renamed function of the current logic

yeah i saw that

Wasted lines of code personally but I guess there are reasons

well, should we merge in 7.0.4?

655 is more important than 660 imo

655 has a ton of bug fixes in it relative to the earlier versions that have spec.alpha

Well 660 is already in the proposal so moving stable to 655 makes sense for now too

literally the only change in 660 is throwing those warnings 😛

Hahahaha

Yeah let's do 655

cool

We can keep bumping the proposal version prior to release

using versions earlier than 655 was getting unusable for me

so should i merge https://github.com/hoplon/hoplon/pull/196 then?