Fork me on GitHub
#hoplon
<
2017-06-30
>
flyboarder03:06:35

@thedavidmeister would you be willing to rework the tests in another PR?

flyboarder03:06:03

I personally dont use tests yet but I thinkt the cljs direction would be faster?

thedavidmeister03:06:11

sooo much better

thedavidmeister03:06:53

i would be happy to put up a PR that moves the selenium tests to cljs equivalents

thedavidmeister03:06:03

- all the web driver wrappers i know about for clojure are essentially unmaintained

thedavidmeister03:06:46

- selenium seems to inevitably come with "random" bugs that cause builds to fail quite often when you have 1k+ assertions

thedavidmeister03:06:25

- cljs tests are at least one or two OOM faster because there's no need to setup a web server and render entire pages to test one tiny element in the DOM

thedavidmeister03:06:05

- it's much easier to write tests that make assertions directly against DOM elements generated by hoplon than trying to scrape the DOM (e.g. what if a previous test mutated the element that you want to inspect?)

thedavidmeister03:06:45

- selenium commonly breaks when a new version of chrome/firefox comes out, not because your code is broken but because web driver needs an update to its interface with the browser version you want to use

thedavidmeister03:06:54

i'll just put up a tx now

thedavidmeister04:06:37

@flyboarder https://github.com/hoplon/hoplon/issues/174 is a perfect example of something you might want to spend 10-15 mins writing some simple tests for if you had cljs tests in place 🙂