Fork me on GitHub
#hoplon
<
2016-11-30
>
onetom08:11:10

@jumblerg thanks! i will try still today. in the meantime we started to work out form use-cases on this branch: https://github.com/addplus/ui/tree/forms and we hit an old issue which is still present to my surprise: https://github.com/hoplon/ui/issues/9 i've updated our reproduction case in https://github.com/addplus/tpl-example to use hoplon/ui 0.1.0-SNAPSHOT but the issue is still there. since you were reworking bind-in! not to bother handling rest arguments, i think that might solve this issue, so it could go into master already, no?

onetom09:11:50

the use-case where this is an issue is when we want to show a red border around a form input field if there are validation errors associated to it.

onetom09:11:29

if you think we shouldn't upgrade bind-in! yet, then i would submit a fix for the current implementation

onetom10:11:01

@jumblerg just compared hoplon/hoplon/master with jumblerg/hoplon/optimizations and with boot test -e, every option off in timeline, i get 1.28s vs 1.20s only on my addplus/ui/perf branch (im on the revert vflatten commit though. not sure if that's the right one)

jumblerg13:11:31

@onetom: well, that's a little anyway. results may vary.

alandipert13:11:28

@laforge49: ran across your web workers slides and materials, very cool and helpful! thanks

jumblerg16:11:44

@micha: given a task like this in my build pipeline:

(cljs :optimizations o :compiler-options {:elide-asserts true})
and the following task-options:
(task-options!
  cljs  #(assoc-in % [:compiler-options :language-in] :ecmascript5-strict))
can you see any reason why the :ecmascript5-strict keyword should not be applied to the :language-in property of the :compiler-options map?

jumblerg16:11:32

guess this q probably belongs in #boot.

micha16:11:48

@jumblerg because you override it when you instantiate the task

jumblerg16:11:05

ok, i guess i misunderstood the intended behaviour. thanks!

jumblerg16:11:05

seems pretty obvious now that i think about the implementation, which i assume curries the cljs function with a call to partial or something like that.

grant21:11:12

I'm playing with hoplon/ui. It seems like there is a default 3px border on each elem, at least in Chrome. Is there an idiomatic way to set the default border width to 0?

grant21:11:27

Ah, never mind, :b 0. I was overlooking the obvious.

jumblerg22:11:06

@grant: that definitely should not be the case. what version of ui are you using; are you on the latest master?